Better numbering usage + other small updates #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliotwrobson
force-pushed
the
numbering_fix
branch
from
d47f995 to
91952bd
Compare
caleb531
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
@eliotwrobson This all looks great to me! Thank you for the PR!
Merging now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a new counter each time a regex gets parsed. This is useful because parsing multiple regexes could use a large number of states, and having the complexity of the state name increase too much could slow things down.
Also, small changes to iteration logic (using
zip-repeatwhich is faster thanproduct), andisdisjointfor faster set intersection checking.