Create configurable camera #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcburney
reviewed
May 2, 2018
src/renderer/Camera.ts
Outdated
| private dirty: boolean = true; | ||
|
|
||
| /** | ||
| * @param {vec3} position The world-space coordinate to move the camera to, preserving rotation |
armcburney
reviewed
May 2, 2018
src/renderer/Camera.ts
Outdated
| private position: vec3 = vec3.fromValues(0, 0, 0); | ||
| private target: vec3 = vec3.copy(vec3.create(), Camera.defaultDirection); | ||
| private transform: mat4 = mat4.create(); | ||
| private dirty: boolean = true; |
There was a problem hiding this comment.
Could you add a comment for what dirty refers to please?
armcburney
reviewed
May 2, 2018
src/renderer/Camera.ts
Outdated
|
|
||
| /** | ||
| * Represents the orientation of the camera in a scene, defined by a position for the camera and a | ||
| * target for the camera to look at |
There was a problem hiding this comment.
This is a huge nit, but do you think you could use periods at the end of your comments to be consistent with the commenting I have in #11?
armcburney
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12
This models the camera using a position and a target to look at. I added some convenience methods to modify those values. I lazily generate the transformation matrix so we don't do extra work if multiple changes are made before the matrix is read.