Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass lights into to the shader in drawObject.ts #10

Closed
armcburney opened this issue May 1, 2018 · 1 comment
Closed

Pass lights into to the shader in drawObject.ts #10

armcburney opened this issue May 1, 2018 · 1 comment
Assignees
@armcburney
Labels
rendererer todo
Milestone
Shapes and Things

Comments

@armcburney
Copy link
Member

No description provided.

@armcburney armcburney added the todo label May 1, 2018
@armcburney armcburney mentioned this issue May 1, 2018
Merged
@davepagurek davepagurek changed the title Pass in MAX_LIGHTS to fragment shader in drawObject.ts Pass lights into to the shader in drawObject.ts May 1, 2018
@davepagurek
Copy link
Member

Updated title because we sort of need a hardcoded MAX_LIGHTS (you can't have a variable length uniform array.) Mostly we just need to pass in numLights, enforce that it's less than or equal to MAX_LIGHTS, and then populate the entire MAX_LIGHTS elements in the uniform array

@armcburney armcburney self-assigned this May 1, 2018
@armcburney armcburney mentioned this issue May 2, 2018
Merged
@pbardea pbardea added this to the Shapes and Things milestone May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armcburney armcburney

Labels
rendererer todo
Projects
None yet
Milestone
Shapes and Things
Development

No branches or pull requests
3 participants
@pbardea @davepagurek @armcburney