Skip to content
This repository was archived by the owner on Oct 29, 2025. It is now read-only.

Conversation

@alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Nov 9, 2023

We currently mark pre-release on cal.com repo as -rc in suffix. In this PR, we see if the RELEASE_TAG contains -rc, and the prerelease property of the createRelease function is dynamically set based on that.

  • We also only push to dockerhub if it isn't a prerelease by fetching the value of github.event.release.prerelease.
  • We added flavor to meta to only tag latest if it isn't a prerelease using the value of github.event.release.prerelease

@alishaz-polymath
Copy link
Member Author

@krumware Can you please review this one?

@krumware
Copy link
Collaborator

LGTM, will merge and test

@krumware krumware merged commit dbc8aa7 into main Dec 22, 2023
Copy link
Collaborator

@krumware krumware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alishaz-polymath alishaz-polymath deleted the fix/skip-pre-release-tag branch April 15, 2024 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants