Skip to content

fix: filter attendees in emails when seatsShowAttendees is disabled#27520

Merged
anikdhabal merged 3 commits intomainfrom
seated-event
Feb 2, 2026
Merged

fix: filter attendees in emails when seatsShowAttendees is disabled#27520
anikdhabal merged 3 commits intomainfrom
seated-event

Conversation

@anikdhabal
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal commented Feb 2, 2026 •
edited by cubic-dev-ai Bot
Loading

Summary by cubic

Fix attendee emails for seated events to only show the recipient when seatsShowAttendees is off. Supports an explicit override and keeps non-seated events unchanged.

  • Bug Fixes
    • AttendeeScheduledEmail now computes shouldShowAttendees: explicit param > seated setting (seatsShowAttendees, default false) > true for non-seated; filters attendees without mutating the source event.
    • getBooking and confirm.handler include seatsPerTimeSlot and seatsShowAttendees so emails receive correct event data.
    • Added tests for seated/non-seated cases, null defaults, overrides, and reference behavior.

Written for commit 7db5bbc. Summary will update on new commits.

@anikdhabal anikdhabal requested a review from a team as a code owner February 2, 2026 15:06
@graphite-app graphite-app Bot added the core area: core, team members only label Feb 2, 2026
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

emrysal
emrysal approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Fixes the issue.

@emrysal emrysal enabled auto-merge (squash) February 2, 2026 15:12
emrysal
emrysal reviewed Feb 2, 2026
View reviewed changes
Comment thread packages/emails/templates/attendee-scheduled-email.ts
emrysal
emrysal requested changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting logic inversion

@github-actions github-actions Bot marked this pull request as draft February 2, 2026 15:14
auto-merge was automatically disabled February 2, 2026 15:14

Pull request was converted to draft

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

E2E results are ready!

@emrysal emrysal self-requested a review February 2, 2026 16:13
@anikdhabal anikdhabal marked this pull request as ready for review February 2, 2026 16:16
@anikdhabal anikdhabal enabled auto-merge (squash) February 2, 2026 16:17
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@anikdhabal anikdhabal merged commit 7611e0e into main Feb 2, 2026
52 checks passed
@anikdhabal anikdhabal deleted the seated-event branch February 2, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal approved these changes

+1 more reviewer

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core area: core, team members only ready-for-e2e size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anikdhabal @emrysal