Skip to content

fix: remove invalid nested anchor inside button in call history empty state#27506

Merged
Udit-takkar merged 2 commits intocalcom:mainfrom
romitg2:fix/nested-link-in-button
Feb 2, 2026
Merged

fix: remove invalid nested anchor inside button in call history empty state#27506
Udit-takkar merged 2 commits intocalcom:mainfrom
romitg2:fix/nested-link-in-button

Conversation

@romitg2
Copy link
Copy Markdown
Member

@romitg2 romitg2 commented Feb 2, 2026

Problem:

The "Create Cal.ai workflow" button in the call history empty state had a component nested inside

Screenshot 2026-02-02 at 5 37 21 PM
  • once button became unresponsive (probably this was the root cause)

Solution:

Use Button's href prop instead of nesting Link. When href is passed, Button renders as (styled as button) rather than

Screenshot 2026-02-02 at 5 38 09 PM

Video demo: (after fix)

Screen.Recording.2026-02-02.at.5.39.49.PM.mov

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings
  • My PR is too large (>500 lines or >10 files) and should be split into smaller PRs

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Feb 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@romitg2 romitg2 changed the title fix fix: remove invalid nested anchor inside button in call history empty state Feb 2, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@Udit-takkar Udit-takkar merged commit e29662b into calcom:main Feb 2, 2026
66 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync ready-for-e2e size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants