Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seat attendee was fetched and marked as required too early. #7964

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Mar 28, 2023

Caused a "No available users" error during organizer reschedule.

@emrysal emrysal requested a review from zomars as a code owner March 28, 2023 00:44
@emrysal emrysal requested a review from a team March 28, 2023 00:44
@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 0:55AM (UTC)
dhe ❌ Failed (Inspect) Mar 28, 2023 at 0:55AM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 0:55AM (UTC)

// If there is no booking then remove the attendee from the old booking and create a new one
if (!newTimeSlotBooking) {
await prisma.bookingSeat.delete({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cascade.

if (!bookingSeat) {
// if no bookingSeat is given and the userId != owner, 401.
// TODO: Next step; Evaluate ownership, what about teams?
if (booking.user?.id !== req.userId) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guard clause instead of more complex flow before.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 233.24 KB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.36 KB 241.61 KB 69.03% (+/- <0.01%)
/[user] 103.4 KB 336.64 KB 96.18% (+/- <0.01%)
/[user]/[type] 91.85 KB 325.1 KB 92.88% (+/- <0.01%)
/[user]/[type]/embed 91.88 KB 325.12 KB 92.89% (+/- <0.01%)
/[user]/embed 103.47 KB 336.71 KB 96.20% (+/- <0.01%)
/apps 167.17 KB 400.42 KB 114.40% (+/- <0.01%)
/apps/[slug] 190.9 KB 424.14 KB 121.18% (+/- <0.01%)
/apps/[slug]/[...pages] 392.31 KB 625.55 KB 178.73% (+/- <0.01%)
/apps/categories 152.07 KB 385.32 KB 110.09% (+/- <0.01%)
/apps/categories/[category] 155.94 KB 389.18 KB 111.19% (+/- <0.01%)
/apps/installed/[category] 197.04 KB 430.29 KB 122.94% (+/- <0.01%)
/auth/error 19.24 KB 252.48 KB 72.14% (+/- <0.01%)
/auth/forgot-password 25.63 KB 258.87 KB 73.96% (+/- <0.01%)
/auth/forgot-password/[id] 32.83 KB 266.07 KB 76.02% (+/- <0.01%)
/auth/login 40.1 KB 273.34 KB 78.10% (+/- <0.01%)
/auth/logout 7.56 KB 240.8 KB 68.80% (+/- <0.01%)
/availability 155.38 KB 388.63 KB 111.04% (+/- <0.01%)
/availability/[schedule] 272.14 KB 505.38 KB 144.39% (+/- <0.01%)
/availability/troubleshoot 152.76 KB 386.01 KB 110.29% (+/- <0.01%)
/booking/[uid] 123.57 KB 356.81 KB 101.95% (+/- <0.01%)
/bookings/[status] 272.39 KB 505.63 KB 144.47% (+/- <0.01%)
/d/[link]/[slug] 91.5 KB 324.74 KB 92.78% (+/- <0.01%)
/d/[link]/[slug]/embed 91.53 KB 324.77 KB 92.79% (+/- <0.01%)
/event-types/[type] 382.89 KB 616.14 KB 176.04% (+/- <0.01%)
/insights 386.24 KB 619.49 KB 177.00% (+/- <0.01%)
/more 151.7 KB 384.94 KB 109.98% (+/- <0.01%)
/settings/admin 157.16 KB 390.4 KB 111.54% (+/- <0.01%)
/settings/admin/apps 165.84 KB 399.08 KB 114.02% (+/- <0.01%)
/settings/admin/apps/[category] 165.83 KB 399.07 KB 114.02% (+/- <0.01%)
/settings/admin/flags 160.05 KB 393.29 KB 112.37% (+/- <0.01%)
/settings/admin/impersonation 157.44 KB 390.68 KB 111.62% (+/- <0.01%)
/settings/billing 157.27 KB 390.51 KB 111.57% (+/- <0.01%)
/settings/developer/api-keys 186.42 KB 419.66 KB 119.90% (+/- <0.01%)
/settings/developer/webhooks 159.76 KB 393 KB 112.29% (+/- <0.01%)
/settings/developer/webhooks/[id] 190.61 KB 423.85 KB 121.10% (+/- <0.01%)
/settings/developer/webhooks/new 190.47 KB 423.71 KB 121.06% (+/- <0.01%)
/settings/my-account/appearance 171.23 KB 404.48 KB 115.56% (+/- <0.01%)
/settings/my-account/calendars 191.46 KB 424.7 KB 121.34% (+/- <0.01%)
/settings/my-account/conferencing 163.03 KB 396.27 KB 113.22% (+/- <0.01%)
/settings/my-account/general 266.42 KB 499.66 KB 142.76% (+/- <0.01%)
/settings/my-account/profile 274.32 KB 507.56 KB 145.02% (+/- <0.01%)
/settings/security/impersonation 159.31 KB 392.55 KB 112.16% (+/- <0.01%)
/settings/security/password 192.6 KB 425.84 KB 121.67% (+/- <0.01%)
/settings/security/sso 167 KB 400.24 KB 114.36% (+/- <0.01%)
/settings/security/two-factor-auth 161.76 KB 395 KB 112.86% (+/- <0.01%)
/settings/teams 156.9 KB 390.14 KB 111.47% (+/- <0.01%)
/settings/teams/[id]/appearance 171.25 KB 404.5 KB 115.57% (+/- <0.01%)
/settings/teams/[id]/billing 157.14 KB 390.38 KB 111.54% (+/- <0.01%)
/settings/teams/[id]/members 297.14 KB 530.38 KB 151.54% (+/- <0.01%)
/settings/teams/[id]/profile 269.53 KB 502.77 KB 143.65% (+/- <0.01%)
/settings/teams/[id]/sso 167.09 KB 400.34 KB 114.38% (+/- <0.01%)
/signup 25.5 KB 258.74 KB 73.93% (🟢 -0.01%)
/team/[slug] 105.87 KB 339.12 KB 96.89% (+/- <0.01%)
/team/[slug]/[type] 91.5 KB 324.75 KB 92.78% (+/- <0.01%)
/team/[slug]/[type]/embed 91.53 KB 324.78 KB 92.79% (+/- <0.01%)
/team/[slug]/embed 105.94 KB 339.18 KB 96.91% (+/- <0.01%)
/teams 151.92 KB 385.16 KB 110.05% (+/- <0.01%)
/video/meeting-ended/[uid] 14.67 KB 247.91 KB 70.83% (+/- <0.01%)
/video/meeting-not-started/[uid] 14.3 KB 247.54 KB 70.73% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 239.84 KB 68.53% (+/- <0.01%)
/workflows 164.81 KB 398.06 KB 113.73% (+/- <0.01%)
/workflows/[workflow] 294.01 KB 527.25 KB 150.64% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented Mar 28, 2023

Current Playwright Test Results Summary

✅ 52 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/28/2023 01:14:34am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5fbd342

Started: 03/28/2023 01:09:37am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 1Initial Attempt
2.47% (4) 4 / 162 runs
failed over last 7 days
31.48% (51) 51 / 162 runs
flaked over last 7 days

View Detailed Build Results


@zomars zomars merged commit 605f9c6 into main Mar 28, 2023
@zomars zomars deleted the bugfix/allow-organizer-reschedule branch March 28, 2023 01:16
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants