Prevent GCal from sending update #7920
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| //delete original rescheduled booking (no seats event) | ||
| if (!eventType.seatsPerTimeSlot) { | ||
| await prisma.booking.delete({ | ||
| where: { | ||
| id: originalRescheduledBooking.id, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
I needed to borrow this from #7910
| @@ -133,6 +133,7 @@ export default class GoogleCalendarService implements Calendar { | |||
| calendarId: selectedCalendar, | |||
| requestBody: payload, | |||
| conferenceDataVersion: 1, | |||
| sendUpdates: "none", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@joeauyeung @zomars @emrysal are we really fine with these sideeffects?
There was a problem hiding this comment.
Yes, these warnings exists for typical applications "Create a booking" - it's not for booking software that sends booking invites on its own like we do 🙏
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixty-nine Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 60 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/27/2023 02:21:35pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: d78be73 Started: 03/27/2023 02:12:47pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 2 • Retry 1 • Initial Attempt |
4.17% (8)8 / 192 runsfailed over last 7 days |
32.81% (63)63 / 192 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
3.45% (6)6 / 174 runsfailed over last 7 days |
28.16% (49)49 / 174 runsflaked over last 7 days |
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.57% (1)1 / 176 runfailed over last 7 days |
7.39% (13)13 / 176 runsflaked over last 7 days |
Co-authored-by: Omar López <zomars@me.com>
What does this PR do?
This PR fixes the double sending emails & double booking events on Google calendar.
Please see the Loom in the thread for more context.
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
Checklist