Fix: Send responses in confirm booking flow #7830
Conversation
CAL-1287 Differing webhook responses when using "requires confirmation"
Hey guys not sure if you're aware of this issue with the booking creation webhook payload. Everything works great when a normal booking is completed, all custom input responses come through as expected. However, when I change the booking to "Required Confirmation" I don't get the same payload data and am missing some important custom input responses. Please see the images below and you'll notice "responses" is completely missing when "Require Confirmation" is activated. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixty-nine Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/21/2023 08:27:22am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e24626a Started: 03/21/2023 08:22:39am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1 • Initial Attempt |
4.35% (10)10 / 230 runsfailed over last 7 days |
10.87% (25)25 / 230 runsflaked over last 7 days |
hariombalhara
force-pushed
the
hariom/cal-1287-differing-webhook-responses-when-using
branch
from
e9cacc1 to
6e73445
Compare
hariombalhara
force-pushed
the
hariom/cal-1287-differing-webhook-responses-when-using
branch
from
6e73445 to
0930e92
Compare
| }), | ||
| ]); | ||
|
|
||
| export const bookingResponsesDbSchema = z.record(bookingResponse); |
There was a problem hiding this comment.
It allows disconnecting current event type data from the responses collected. It thus fixes scenarios like
- Earlier, a field was of type text and has value "Test" and when we changed the type to "checkbox" booking started showing the value as
false - Earlier, a field was there and was recorded in a booking but after removing that field/question, it stopped showing in existing bookings as well.
| @@ -765,6 +773,22 @@ export const bookingsRouter = router({ | |||
| scheduledJobs: true, | |||
| }, | |||
| }); | |||
|
|
|||
| const bookingFields = bookingRaw.eventType | |||
There was a problem hiding this comment.
If eventType has been deleted and then booking is being confirmed, there are no bookingFields.
hariombalhara
force-pushed
the
hariom/cal-1287-differing-webhook-responses-when-using
branch
from
0930e92 to
90443d1
Compare
hariombalhara
force-pushed
the
hariom/cal-1287-differing-webhook-responses-when-using
branch
from
90443d1 to
dec7d78
Compare
hariombalhara
force-pushed
the
hariom/cal-1287-differing-webhook-responses-when-using
branch
from
dec7d78 to
e24626a
Compare
hariombalhara
deleted the
hariom/cal-1287-differing-webhook-responses-when-using
branch
What does this PR do?
Fixes #7810
Environment: Production
Type of change
How should this be tested?
responsesanduserFieldsResponsesprops.responsesanduserFieldsResponsesprops are still there.Checklist