-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - add team members to emails #7207
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
98cd23b
On booking add team members & translation
joeauyeung d128c3e
Add team members to round robin create
joeauyeung d05fe6f
Only update calendars on reschedule if there is a calendar reference
joeauyeung cbdda75
Send email on reschedules
joeauyeung 3dcb5dd
Send team email on cancelled event
joeauyeung 5e9fda7
Add team members to calendar event description
joeauyeung ff93467
Clean up
joeauyeung 24becee
Convert other emails to organizer & teams
joeauyeung b4c7145
Type check fixes
joeauyeung 94a6cae
More type fixes
joeauyeung 8f3f17b
Change organizer scheduled input to an object
joeauyeung 5a9f20b
early return updateCalendarEvent
joeauyeung 5288fec
Introduce team member type
joeauyeung 9035b05
Merge branch 'main' into teams-include-team-members-in-email
joeauyeung 97d7842
Fix type errors
joeauyeung b4fb91f
Merge branch 'main' into teams-include-team-members-in-email
zomars 25a3d97
Put team members before attendees
joeauyeung c4c629c
Remove lodash cloneDeep
joeauyeung 7936b3a
Merge branch 'main' into teams-include-team-members-in-email
joeauyeung e6dfa35
Update packages/core/EventManager.ts
joeauyeung 9f121ff
Remove booking select object
joeauyeung fe94312
Revert "Remove booking select object"
joeauyeung 8ee8d7a
Refactor email manager (#7270)
joeauyeung e17f69e
Type change
joeauyeung 3ecbebd
Remove conditional check for updateAllCalendarEvents
joeauyeung 9f463dc
Merge branch 'main' into teams-include-team-members-in-email
zomars File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -255,7 +255,6 @@ export default class EventManager { | |
results.push(result); | ||
} | ||
|
||
// Update all calendar events. | ||
results.push(...(await this.updateAllCalendarEvents(evt, booking))); | ||
|
||
const bookingPayment = booking?.payment; | ||
|
@@ -442,7 +441,7 @@ export default class EventManager { | |
// Bookings should only have one calendar reference | ||
calendarReference = booking.references.filter((reference) => reference.type.includes("_calendar"))[0]; | ||
if (!calendarReference) { | ||
throw new Error("bookingRef"); | ||
return []; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of throwing an error if no calendar references, we just return an empty array |
||
} | ||
const { uid: bookingRefUid, externalCalendarId: bookingExternalCalendarId } = calendarReference; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer checking for calendar references here