feat(app-store): add facetime app to app-store #7174
Conversation
Add the facetime app to the app-store allowing for facetime web links and facetime app link schemes. fixes calcom#6965
|
@Mythie is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
thank you so much! feel free to change author to youe github username and not Cal.com Inc |
| "linkType": "static", | ||
| "type": "integrations:facetime_video", | ||
| "label": "Facetime", | ||
| "organizerInputPlaceholder": "https://facetime.apple.com/join... or facetime:<contact>", |
There was a problem hiding this comment.
facetime: would only work if the facetime app is installed. Otherwise this link would just not work.
So, I think we shouldn't suggest that. If facetime works through browser that's the right thing to do.
I hope facetime website would automatically open facetime app if it's installed.
There was a problem hiding this comment.
It does open the app when visiting the website, however that still requires that a user generate a FaceTime link. If we’re happy for that to be required I can make the update in a few hours once it’s morning again.
There was a problem hiding this comment.
I think that would be a better approach because the organizer can generate the link once. If we allow facetime: scheme, bookers won't be able to join meeting by clicking on the link they receive.
There was a problem hiding this comment.
Latest commit updates the config to follow the new decision on the FaceTime links, the placeholder is also updated correspondingly:
Update the regex and placeholder for the facetime app to reflect the decisions to only accept https://facetime.apple.com links. This was decided as it means that all participants can join a meeting even in the event that they don't have an Apple device.
hariombalhara
added
♻️ autoupdate
* feat(app-store): add facetime app to app-store Add the facetime app to the app-store allowing for facetime web links and facetime app link schemes. fixes calcom#6965 * Update packages/app-store/facetime/config.json * Remove unneeded files and make app follow the new app rules * fix(app-store): update facetime app config Update the regex and placeholder for the facetime app to reflect the decisions to only accept https://facetime.apple.com links. This was decided as it means that all participants can join a meeting even in the event that they don't have an Apple device. --------- Co-authored-by: Peer Richelsen <peer@cal.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
* feat(app-store): add facetime app to app-store Add the facetime app to the app-store allowing for facetime web links and facetime app link schemes. fixes calcom#6965 * Update packages/app-store/facetime/config.json * Remove unneeded files and make app follow the new app rules * fix(app-store): update facetime app config Update the regex and placeholder for the facetime app to reflect the decisions to only accept https://facetime.apple.com links. This was decided as it means that all participants can join a meeting even in the event that they don't have an Apple device. --------- Co-authored-by: Peer Richelsen <peer@cal.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
What does this PR do?
Add the FaceTime app to the app-store allowing for bookings locations using FaceTime web links and FaceTime app link schemes.
Fixes #6965
Loom Video
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist