perf: remove _count children query from EventType and Workflow repositories #27309
+18
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
_count: { select: { children: true } }pattern from Prisma queries that was generating expensive aggregate queries like:Changes:
_countchildren select fromeventTypeRepository.ts(2 occurrences in workflow-related queries)_countchildren select fromWorkflowRepository.ts(4 occurrences)WorkflowListTypetype definition to remove the_countpropertyWorkflowListPage.tsxto no longer display the child count(+N)in tooltipsUpdates since last revision
get.handler.tsto force Turborepo to regenerate TRPC types (workaround for cyclic dependency between@calcom/trpcand@calcom/featurespreventing proper cache invalidation)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
(+N)child count suffixChecklist
Link to Devin run: https://app.devin.ai/sessions/6c7de59aad554dd59c7db4d50cf6e53d
Requested by: @keithwillcode
Human Review Notes
get.handler.tsis a workaround to force TRPC type regeneration due to Turborepo caching issues (cyclic dependency prevents adding@calcom/featuresas a proper dependency of@calcom/trpc)