-
Notifications
You must be signed in to change notification settings - Fork 11.7k
perf: optimize EventType children count query using raw SQL #27308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
keithwillcode
wants to merge
4
commits into
main
Choose a base branch
from
devin/1769534187-remove-eventtype-children-count
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
perf: optimize EventType children count query using raw SQL #27308
keithwillcode
wants to merge
4
commits into
main
from
devin/1769534187-remove-eventtype-children-count
+105
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Replace Prisma's _count.children aggregation with an optimized raw SQL query that uses the parentId index instead of doing a full table scan. The original Prisma-generated query scanned ~3.5M rows (825ms) because the subquery had no WHERE clause. The new query filters the subquery to only count children for the specific IDs being queried, reducing execution time significantly by leveraging the existing parentId index. Changes: - Add getEventTypesWithChildrenCount helper using raw SQL in WorkflowRepository - Add findByIdsIncludeChildrenCount method to EventTypeRepository - Add enrichWorkflowsWithChildrenCount to enrich workflow data with counts - Update all workflow fetching methods to use the optimized query - Update eventTypeRepository findById and findByIdForOrgAdmin methods Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keithwillcode
commented
Jan 27, 2026
packages/features/ee/workflows/repositories/WorkflowRepository.ts
Outdated
Show resolved
Hide resolved
keithwillcode
commented
Jan 27, 2026
packages/features/ee/workflows/repositories/WorkflowRepository.ts
Outdated
Show resolved
Hide resolved
keithwillcode
commented
Jan 27, 2026
packages/features/ee/workflows/repositories/WorkflowRepository.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
keithwillcode
commented
Jan 27, 2026
packages/features/eventtypes/repositories/eventTypeRepository.ts
Outdated
Show resolved
Hide resolved
keithwillcode
commented
Jan 27, 2026
packages/features/eventtypes/repositories/eventTypeRepository.ts
Outdated
Show resolved
Hide resolved
…alls Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
The optimization for eventTypeRepository.findById and findByIdForOrgAdmin caused type errors because the tRPC types expect _count.children to be present in the workflow.activeOn.eventType structure. The main performance optimization remains in WorkflowRepository where the raw SQL query is used to efficiently fetch children counts for multiple workflows. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimizes a slow SQL query that counts EventType children. The original Prisma-generated query was doing a full table sequential scan (~3.5M rows, 825ms execution time) because the
_count.childrenaggregation generates a subquery withWHERE 1=1that scans ALL rows.The new approach uses a raw SQL query that filters the subquery to only count children for the specific IDs being queried, leveraging the existing
parentIdindex.Before (Prisma-generated):
After (optimized raw SQL):
This count is used only for displaying "(+N)" in workflow list tooltips to show child event type counts.
Updates since last revision
awaitto allenrichWorkflowsWithChildrenCountcalls in WorkflowRepositoryfindById,findByIdForOrgAdmin) continue to use Prisma's_count.childrenbecause the tRPC types expect this structure and these are single event type queries with minimal performance impact.Link to Devin run: https://app.devin.ai/sessions/be18fff405b642a7aa33be8bf5ca5146
Requested by: @keithwillcode
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist for Human Review
"public"."EventType"schema is appropriate for all environmentsas EnrichActiveOn<T>[]type cast inenrichWorkflowsWithChildrenCount