-
Notifications
You must be signed in to change notification settings - Fork 11.7k
docs: api v2 and examples app setup #27290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
supalarry
wants to merge
3
commits into
main
Choose a base branch
from
lauris/cal-7125-docs-api-v2-atoms-examples-app-setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs: api v2 and examples app setup #27290
supalarry
wants to merge
3
commits into
main
from
lauris/cal-7125-docs-api-v2-atoms-examples-app-setup
+256
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/api/v2/README-PLATFORM.md">
<violation number="1" location="apps/api/v2/README-PLATFORM.md:31">
P2: Replace the concrete OAuth secret values in the docs with placeholders (e.g., `<PLAINTEXT_SECRET>`). Shipping real-looking secrets in documentation can lead to accidental exposure or reuse.
(Based on your team's feedback about avoiding exposing actual OAuth client secrets.) [FEEDBACK_USED]</violation>
</file>
<file name="apps/api/v2/README.md">
<violation number="1" location="apps/api/v2/README.md:16">
P2: The env file rename path is incorrect (`apps/api/v2.env` instead of `apps/api/v2/.env`), which will mislead developers and cause the app to miss the env file. Update the path to include the directory separator.</violation>
</file>
<file name="apps/api/v2/scripts/generate-secrets.ts">
<violation number="1" location="apps/api/v2/scripts/generate-secrets.ts:5">
P1: Rule violated: **Avoid Logging Sensitive Information**
Remove logging of generated secrets to avoid exposing sensitive authentication data in logs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
- Fix env file path typo in README.md (apps/api/v2.env -> apps/api/v2/.env) - Write generated secrets to file instead of logging to console - Add .generated-secrets to gitignore - Update README-PLATFORM.md to reflect new secret generation behavior Co-Authored-By: unknown <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expands API v2 and platform examples app setup documentation to streamline local development, with clearer docs, pre-filled env examples, and a new secret generator script.
Summary of Changes
.generated-secretsfile (not logged to console for security)apps/api/v2/.envinstead ofapps/api/v2.env)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
apps/api/v2/README.mdto set up API v2 locallyyarn generate-secretsinapps/api/v2and verify secrets are written to.generated-secretsfile (not logged to console)apps/api/v2/README-PLATFORM.mdto set up the platform examples appChecklist
Link to Devin run: https://app.devin.ai/sessions/eac833c0aaf84b7a83c3885abf8a2f07
Requested by: unknown ()