-
Notifications
You must be signed in to change notification settings - Fork 11.7k
Fix/booking limit gh 27261 #27287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/booking limit gh 27261 #27287
Conversation
|
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Graphite Automations"Send notification to Community team when High Priority PR opened" took an action on this PR • (01/27/26)2 teammates were notified to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/features/tsconfig.json">
<violation number="1" location="packages/features/tsconfig.json:27">
P2: Test files no longer excluded from the features tsconfig; `**/*.test.*` removal causes non-__tests__ test files to be compiled/typechecked in builds</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "exclude": [ | ||
| "dist", | ||
| "build", | ||
| "**/node_modules/**", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Test files no longer excluded from the features tsconfig; **/*.test.* removal causes non-tests test files to be compiled/typechecked in builds
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/features/tsconfig.json, line 27:
<comment>Test files no longer excluded from the features tsconfig; `**/*.test.*` removal causes non-__tests__ test files to be compiled/typechecked in builds</comment>
<file context>
@@ -5,12 +5,29 @@
+ "exclude": [
+ "dist",
+ "build",
+ "**/node_modules/**",
+ "**/__mocks__/*",
+ "**/__tests__/*",
</file context>
Fixes GH-27261
Corrected timezone resolution logic for booking limits. The system now prioritizes the Event Type timezone, then the Schedule timezone, and finally the User timezone (Organizer) to determine the "day" boundary. This prevents bookings on different local days (but same UTC day) from being incorrectly blocked by daily limits.