-
Notifications
You must be signed in to change notification settings - Fork 11.7k
fix: improve French translations and handle email invites #27286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: improve French translations and handle email invites #27286
Conversation
Updating 'Connexion' to 'Se connecter' for consistency with Google/SAML login buttons and improving the identifier label.
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/public/static/locales/fr/common.json">
<violation number="1" location="apps/web/public/static/locales/fr/common.json:2293">
P2: French translation for "identifier" changed to a verb phrase (“S'identifier”), but the English source is the noun label “Identifier”, so this becomes a semantic mistranslation for the booking questions identifier column/field.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Fixes French login label and prevents NaN userId when adding email-invite members to team event types. Improves UI consistency and avoids assignment errors.
Bug Fixes
i18n
Written for commit 30eb85d. Summary will update on new commits.