-
Notifications
You must be signed in to change notification settings - Fork 11.7k
test: add E2E test to verify no RSC prefetch on team page load #27263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… rate limits Co-Authored-By: alex@cal.com <me@alexvanandel.com>
Co-Authored-By: alex@cal.com <me@alexvanandel.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: alex@cal.com <me@alexvanandel.com>
Co-Authored-By: alex@cal.com <me@alexvanandel.com>
Co-Authored-By: alex@cal.com <me@alexvanandel.com>
Co-Authored-By: alex@cal.com <me@alexvanandel.com>
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/playwright/team-page-no-prefetch.e2e.ts">
<violation number="1" location="apps/web/playwright/team-page-no-prefetch.e2e.ts:39">
P1: Rule violated: **E2E Tests Best Practices**
Add a URL assertion after navigation to fail fast on unexpected redirects, as required by the E2E Tests Best Practices rule.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Devin AI is addressing Cubic AI's review feedbackNew feedback has been sent to the existing Devin session. ✅ Pushed commit |
Co-Authored-By: alex@cal.com <me@alexvanandel.com>
What does this PR do?
Adds an E2E test to verify that the
prefetch={false}fix in PR #27260 is working correctly. The test ensures that no RSC prefetch requests (requests with_rscquery parameter) are made for event type pages when loading the team page, which was causing excessive Google Calendar API rate limit hits.Updates since last revision
/team/{teamSlug}/{eventTypeSlug}patterncountEventTypePrefetchRequestsfor clarityMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Run the E2E test locally:
The test:
/team/{slug})/team/{teamSlug}/{eventTypeSlug}patternExpected result: Both tests pass, confirming that
prefetch={false}prevents Next.js from prefetching event type pages when they enter the viewport.Human Review Checklist
prefetch={false}fromteam-view.tsxand verify the test fails^/team/${teamSlug}/[^/]+$correctly matches event type URLs without false positivesChecklist
Link to Devin run: https://app.devin.ai/sessions/20d6b6950eab4841b44f488bbf30fbc9
Requested by: @emrysal (alex@cal.com)