Skip to content

Conversation

@eeshm
Copy link
Contributor

@eeshm eeshm commented Jan 26, 2026

What does this PR do?

Headers and subheaders were fixed to the top when scrolling on some pages like workflows, routing forms, and org members pages.

Only some pages showed this behaviour because other pages (event types, bookings) use ShellMainAppDir which never had sticky position.

Visual Demo (For contributors especially)

  • before :
cursorful-video-1769430261186.mp4
  • after
cursorful-video-1769430334656.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • no breaking changes
  • Go to workflows page, the header scrolls with content.
  • all pages using ShellMain fixed

@github-actions github-actions bot added community Created by Linear-GitHub Sync consumer Medium priority Created by Linear-GitHub Sync labels Jan 26, 2026
@graphite-app graphite-app bot requested a review from a team January 26, 2026 12:48
@eeshm eeshm changed the title fix: remove sticky positioning from page headers in pages using Shell… fix: remove sticky positioning from page headers in pages on scroll Jan 26, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

eunjae-lee
eunjae-lee previously approved these changes Jan 26, 2026
@eunjae-lee eunjae-lee added the run-ci Approve CI to run for external contributors label Jan 26, 2026
@eunjae-lee eunjae-lee enabled auto-merge (squash) January 26, 2026 13:36
Copy link
Member

@dhairyashiil dhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messing with other pages as well, check event types/advanced page

Screen.Recording.2026-01-26.at.7.05.08.PM.mov

@dhairyashiil dhairyashiil disabled auto-merge January 26, 2026 13:37
@eunjae-lee
Copy link
Contributor

messing with other pages as well, check event types/advanced page

Thanks for spotting !

@dhairyashiil
Copy link
Member

Thanks for spotting !

welcome : )

@dhairyashiil
Copy link
Member

@eeshm i have pushed one commit, this works as expected on workflows pages and not creating regression on other pages, could you please check if what i pushed is the optimal solution and if yes could you apply the same on other pages as well? if this is not optimal, please feel free to change the implementation.

please check all the pages after your fix, and attach all the videos

@dhairyashiil dhairyashiil marked this pull request as draft January 26, 2026 13:54
@eeshm
Copy link
Contributor Author

eeshm commented Jan 26, 2026

hi, thanks for catching it and sorry my approach was too broad. Your approach mostly look fine, i'll verify it locally and apply changes on other pages.

Applied disableSticky={true} to remaining affected pages:
- Routing Forms page
- Organization Members view
- Platform Members view
@eeshm
Copy link
Contributor Author

eeshm commented Jan 26, 2026

hi @dhairyashiil, checked locally and your fix was optimal and is not creating regression on other pages.

additional changes applied to:

  • apps/routing-forms/forms/[[...pages]]/Forms.tsx - Routing Forms page
  • settings/organizations/(org-user-only)/[id]/members/layout.tsx - Org Members view
  • settings/platform/members/layout.tsx - Platform Members view

videos:

  • cursorful-video-1769445896650.mp4
  • cursorful-video-1769450246704.mp4
  • /settings/platform/members - can't verify (subscription needed) ), but follows the same pattern

@eeshm eeshm marked this pull request as ready for review January 26, 2026 18:01
@eeshm eeshm requested a review from a team as a code owner January 26, 2026 18:01
@eeshm eeshm requested a review from dhairyashiil January 26, 2026 18:02
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Copy link
Member

@dhairyashiil dhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhairyashiil dhairyashiil added run-ci Approve CI to run for external contributors and removed run-ci Approve CI to run for external contributors labels Jan 26, 2026
@dhairyashiil dhairyashiil enabled auto-merge (squash) January 26, 2026 20:37
@dhairyashiil dhairyashiil merged commit 72d6fcb into calcom:main Jan 26, 2026
72 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync consumer Medium priority Created by Linear-GitHub Sync ready-for-e2e run-ci Approve CI to run for external contributors size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove fixed headers and subheaders on scroll

4 participants