fix: exclude third-party video apps from areCalendarEventsEnabled setting #27230
+47
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
areCalendarEventsEnabledis set tofalsein the Platform API, video meeting creation for third-party video apps (like Daily.co) was being skipped entirely. This caused themeetingUrlfield in webhook payloads to contain the location identifier (integrations:daily) instead of the actual video meeting URL.This PR adds a
skipCalendarEventoption toEventManager.create()that:The calling code in
handleConfirmation.tsandRegularBookingService.tsnow uses this option whenareCalendarEventsEnabledis false, ensuring video meetings are still created while respecting the platform customer's preference to manage their own calendar events.Updates since last revision
user-bookings.e2e-spec.tsto verify the new behavior:EventManager.createIS called withskipCalendarEvent: truewhenareCalendarEventsEnabledis falseMandatory Tasks (DO NOT REMOVE)
How should this be tested?
areCalendarEventsEnabled: falseand a Daily.co video location (integrations:daily)POST /v2/bookings/:bookingUid/confirmmetadata.videoCallUrlinstead ofintegrations:dailyHuman Review Checklist
skipCalendarEvent: true)areCalendarEventsEnabledis false is the desired behavior for platform customersshouldSkipCalendarEvents = !areCalendarEventsEnabled || skipCalendarSyncTaskCreationLink to Devin run: https://app.devin.ai/sessions/376d3fb807d94924b020a2f3045acaee
Requested by: @ThyMinimalDev