Skip to content

fix: return 400 instead of 500 for invalid email in iCal generation #27217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hbjORbj merged 3 commits into from
Jan 25, 2026
Merged

fix: return 400 instead of 500 for invalid email in iCal generation #27217

hbjORbj merged 3 commits into from
Jan 25, 2026
+97 −2

Conversation

@hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 25, 2026 •
edited
Loading

What does this PR do?

Fixes a 500 error that occurs when rescheduling phone-only bookings.

Request path:

POST /api/book/event
  → RegularBookingService.rescheduleBooking()
    → handleSeats (for seated bookings)
      → combineTwoSeatedBookings() / moveSeatedBookingToNewTimeSlot()
        → sendRescheduledEmailsAndSMS()
          → AttendeeRescheduledEmail.getNodeMailerPayload()
            → generateIcsFile()
              → generateIcsString()
                → ics.createEvent() → Yup ValidationError (500)

The ics library throws a Yup ValidationError when an attendee has a phone number instead of an email. Since Yup ValidationError is not an Error instance, it falls through error handling to a generic 500.

Fix: Catch the ValidationError at the source (generateIcsString.ts) and convert it to ErrorWithCode.BadRequest, returning a proper 400 status code.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@devin-ai-integration @hbjORbj
fix: return 400 instead of 500 for invalid email in iCal generation
64446ce 
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
@devin-ai-integration
Copy link
Contributor

devin-ai-integration bot commented Jan 25, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration @hbjORbj
test: add unit tests for error handling in generateIcsString
cd788bb 
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

E2E results are ready!

hbjORbj
hbjORbj commented Jan 25, 2026
View reviewed changes
packages/emails/lib/generateIcsString.ts
// The ics library throws Yup ValidationError objects (not Error instances) for invalid data like invalid email formats.
// Convert these to ErrorWithCode.BadRequest so they return 400 instead of falling through to a generic 500.
if (icsEvent.error.name === "ValidationError") {
throw new ErrorWithCode(ErrorCode.BadRequest, icsEvent.error.message);
Copy link
Contributor Author

@hbjORbj hbjORbj Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this propagates all the way to getServerErrorFromUnknown, at which this gets converted into HttpError with status code 400

hbjORbj
hbjORbj commented Jan 25, 2026
View reviewed changes
packages/emails/lib/generateIcsString.test.ts
Comment on lines +177 to +182
// Simulate a Yup ValidationError (which has name: "ValidationError")
const validationError = {
name: "ValidationError",
message: "attendees[0].email must be a valid email",
errors: ["attendees[0].email must be a valid email"],
};
Copy link
Contributor Author

@hbjORbj hbjORbj Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that ics library throws a validation error in this format

@hbjORbj hbjORbj marked this pull request as ready for review January 25, 2026 13:26
@hbjORbj hbjORbj requested a review from a team January 25, 2026 13:26
@graphite-app graphite-app bot added foundation core area: core, team members only labels Jan 25, 2026
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Jan 25, 2026
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@hbjORbj hbjORbj enabled auto-merge (squash) January 25, 2026 13:36
emrysal
emrysal approved these changes Jan 25, 2026
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments, good to go

@hbjORbj hbjORbj merged commit 6a532c2 into main Jan 25, 2026
48 checks passed
@hbjORbj hbjORbj deleted the devin/1769326283-fix-ics-validation-error-code branch January 25, 2026 15:02
@hbjORbj hbjORbj mentioned this pull request Jan 26, 2026
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@emrysal emrysal emrysal approved these changes

Assignees

No one assigned

Labels

core area: core, team members only foundation ready-for-e2e size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbjORbj @emrysal