-
Notifications
You must be signed in to change notification settings - Fork 11.7k
feat: add hidden toggle support for managed event types #27204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Deepak22448
wants to merge
3
commits into
calcom:main
Choose a base branch
from
Deepak22448:feat/managed-event-hidden-toggle-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add hidden toggle support for managed event types #27204
Deepak22448
wants to merge
3
commits into
calcom:main
from
Deepak22448:feat/managed-event-hidden-toggle-fix
+497
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add hidden toggle with lock/unlock control for parent managed events - Propagate hidden value to children when locked - Fix bug where toggling hidden from listing deleted child events - Add unit and E2E tests Fixes calcom#25903
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx">
<violation number="1" location="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx:784">
P2: `isHiddenFieldLocked` is derived from `getValues("metadata")`, which doesn’t subscribe to form updates. Lock/unlock changes to metadata won’t trigger a re-render, so the children assignment UI can receive a stale lock state.</violation>
</file>
<file name="apps/web/playwright/managed-event-types.e2e.ts">
<violation number="1" location="apps/web/playwright/managed-event-types.e2e.ts:301">
P2: Propagation test can pass without validating anything when no child events exist; it should assert at least one child switch exists before checking disabled state.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx
Outdated
Show resolved
Hide resolved
- Use useWatch instead of getValues for metadata to ensure re-renders on lock/unlock changes - Add assertion in E2E test to ensure at least one child exists before validation
Contributor
Author
|
@pallava-joshi CI isn’t running because this PR is from an external contributor. It needs the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
Created by Linear-GitHub Sync
enterprise
area: enterprise, audit log, organisation, SAML, SSO
✨ feature
New feature or request
✅ good first issue
Good for newcomers
Medium priority
Created by Linear-GitHub Sync
⚡ Quick Wins
A collection of quick wins/quick fixes that are less than 30 minutes of work
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for admins to control the hidden field at the parent managed event level, with propagation to child events and lock/unlock functionality.
Previously, managed event types didn't have a hidden toggle for parent events. Each child event could be marked as hidden individually, but this couldn't be controlled at the parent level.
Key Changes
Demo
Screen.Recording.2026-01-24.at.12.06.26.PM.mov
How to Test
Fixes #25903