Skip to content

Conversation

@Deepak22448
Copy link
Contributor

@Deepak22448 Deepak22448 commented Jan 24, 2026

What does this PR do?

Adds support for admins to control the hidden field at the parent managed event level, with propagation to child events and lock/unlock functionality.

Previously, managed event types didn't have a hidden toggle for parent events. Each child event could be marked as hidden individually, but this couldn't be controlled at the parent level.

Key Changes

  • Add hidden toggle to managed event type editor header
  • Add lock/unlock indicator for the hidden field
  • Propagate parent's hidden value to children when field is locked
  • Allow per-child hidden values when field is unlocked
  • Fix bug where toggling hidden from listing page deleted all child events
  • Add unit tests for hidden field propagation logic
  • Add E2E tests for toggle, lock/unlock, and propagation functionality

Demo

Screen.Recording.2026-01-24.at.12.06.26.PM.mov

How to Test

  1. Create a managed event type as an admin
  2. Toggle the hidden switch on/off and verify it saves
  3. Toggle the lock/unlock icon next to the hidden field
  4. When locked: verify all children inherit the parent's hidden value
  5. When unlocked: verify children can have individual hidden values set via the assignment tab
  6. Add new team members and verify they get the correct hidden value based on the lock state

Fixes #25903

- Add hidden toggle with lock/unlock control for parent managed events
- Propagate hidden value to children when locked
- Fix bug where toggling hidden from listing deleted child events
- Add unit and E2E tests

Fixes calcom#25903
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 24, 2026
@github-actions github-actions bot added enterprise area: enterprise, audit log, organisation, SAML, SSO Medium priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers ✨ feature New feature or request labels Jan 24, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 7 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx">

<violation number="1" location="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx:784">
P2: `isHiddenFieldLocked` is derived from `getValues("metadata")`, which doesn’t subscribe to form updates. Lock/unlock changes to metadata won’t trigger a re-render, so the children assignment UI can receive a stale lock state.</violation>
</file>

<file name="apps/web/playwright/managed-event-types.e2e.ts">

<violation number="1" location="apps/web/playwright/managed-event-types.e2e.ts:301">
P2: Propagation test can pass without validating anything when no child events exist; it should assert at least one child switch exists before checking disabled state.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Deepak22448 and others added 2 commits January 24, 2026 12:43
- Use useWatch instead of getValues for metadata to ensure re-renders on lock/unlock changes
- Add assertion in E2E test to ensure at least one child exists before validation
@Deepak22448
Copy link
Contributor Author

Deepak22448 commented Jan 26, 2026

@pallava-joshi CI isn’t running because this PR is from an external contributor. It needs the run-ci label from a maintainer to trigger GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync enterprise area: enterprise, audit log, organisation, SAML, SSO ✨ feature New feature or request ✅ good first issue Good for newcomers Medium priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Managed Event doesn't yet support a Hidden Event toggle in parent event

2 participants