-
Notifications
You must be signed in to change notification settings - Fork 11.5k
fix: OOO pagination updated to standard and removed infinite scroll #26494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Adarsh9977 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/trpc/server/routers/viewer/ooo/outOfOfficeEntriesList.schema.ts">
<violation number="1" location="packages/trpc/server/routers/viewer/ooo/outOfOfficeEntriesList.schema.ts:5">
P2: Missing minimum constraint on `offset`. Negative values would cause Prisma `skip` errors. Consider adding `.min(0)` for consistency with `limit` validation.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/trpc/server/routers/viewer/ooo/outOfOfficeEntriesList.schema.ts
Outdated
Show resolved
Hide resolved
dhairyashiil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change alters the intended behavior, so it would need to go through a new feature request first. Could you please create an issue using the feature request template and link this PR to it?
Once a team member approves the change, we can come back and continue reviewing this PR.
On a personal note, I think the infinite scroll looks good. I’m not sure why we need pagination just for consistency and it’s unlikely most users will have enough OOO entries to benefit from it.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Screen.Recording.2026-01-06.at.1.08.39.PM.mov
Screen.Recording.2026-01-06.at.1.05.56.PM.mov
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Switches the Out of Office list to standard pagination using limit/offset and removes infinite scroll. Aligns with the Linear request to use consistent pagination in OOO.
Written for commit 01bb02a. Summary will update on new commits.