fix(ui): Remove double hover effect on destructive dropdown items #26441
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `hover:bg-subtle` from DropdownMenuItem to prevent visual conflict with DropdownItem's hover states. The child DropdownItem component already handles hover backgrounds appropriately: - Non-destructive items: hover:bg-subtle - Destructive items: hover:bg-error This fixes the layered hover effect where both parent and child backgrounds were visible simultaneously on destructive actions. Closes calcom#26256 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@jeremylongshore is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
Contributor
|
It's not fixing the issue, thanks for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the double hover effect on destructive dropdown menu items where both the parent
DropdownMenuItem's subtle gray background and the childDropdownItem's error red background appeared simultaneously on hover.Root cause:
DropdownMenuItemappliedhover:bg-subtleunconditionally, conflicting withDropdownItem'shover:bg-errorfor destructive items.Solution: Remove
hover:bg-subtlefromDropdownMenuItem. The childDropdownItemcomponent already handles hover backgrounds appropriately:hover:bg-subtlehover:bg-errorThis is a minimal, targeted fix that doesn't affect other styling or behavior.
Before/After
Before: Both backgrounds visible (gray + red layered)
After: Only the appropriate background (red for destructive, gray for non-destructive)
Test plan
Closes #26256
🤖 Generated with Claude Code