-
Notifications
You must be signed in to change notification settings - Fork 11.5k
feat: Add action‑item support to mobile “More” page and added navigation to refer page #26431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add action‑item support to mobile “More” page and added navigation to refer page #26431
Conversation
|
@abhayymishraa is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/more/more-page-view.tsx">
<violation number="1" location="apps/web/modules/more/more-page-view.tsx:19">
P2: When `user` is undefined (session loading), `publicPageUrl` will be malformed (e.g., `https://cal.com/undefined`). Consider adding an early return or guard before constructing the URL and rendering the bottom nav items.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| const { data: session } = useSession(); | ||
| const user = session?.user; | ||
| const isAdmin = user?.role === UserPermissionRole.ADMIN; | ||
| const publicPageUrl = `${getBookerBaseUrlSync(user?.org?.slug ?? null)}/${ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: When user is undefined (session loading), publicPageUrl will be malformed (e.g., https://cal.com/undefined). Consider adding an early return or guard before constructing the URL and rendering the bottom nav items.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/more/more-page-view.tsx, line 19:
<comment>When `user` is undefined (session loading), `publicPageUrl` will be malformed (e.g., `https://cal.com/undefined`). Consider adding an early return or guard before constructing the URL and rendering the bottom nav items.</comment>
<file context>
@@ -1,17 +1,49 @@
+ const { data: session } = useSession();
+ const user = session?.user;
+ const isAdmin = user?.role === UserPermissionRole.ADMIN;
+ const publicPageUrl = `${getBookerBaseUrlSync(user?.org?.slug ?? null)}/${
+ user?.orgAwareUsername ?? user?.username
+ }`;
</file context>
✅ Addressed in 438ed44
What does this PR do?
This PR adds support for action items on the mobile More page (e.g., "Copy public page link" and "Skip trial") and ensures that action items do not display the trailing arrow icon, matching the desktop sidebar behavior. It also reuses the existing
useBottomNavItemshook to render these items without creating new components.Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
After
Screen.Recording.2026-01-04.at.6.54.47.PM.mov
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn dev)./morepage (you can simulate mobile view via browser dev tools). Verify that:yarn test) to ensure no regressions.Environment variables: None beyond the usual development setup.
Test data: Any user account with a public profile URL.
Checklist