Skip to content

Conversation

@abhayymishraa
Copy link
Contributor

What does this PR do?

This PR adds support for action items on the mobile More page (e.g., "Copy public page link" and "Skip trial") and ensures that action items do not display the trailing arrow icon, matching the desktop sidebar behavior. It also reuses the existing useBottomNavItems hook to render these items without creating new components.

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

After

Screen.Recording.2026-01-04.at.6.54.47.PM.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Run the app locally (yarn dev).
  2. Log in as a regular user and navigate to the mobile /more page (you can simulate mobile view via browser dev tools). Verify that:
    • The bottom navigation items (View public page, Copy public page link, Refer and earn) appear.
    • The "Copy public page link" button does not display the arrow‑right icon.
    • Clicking "Copy public page link" copies the correct URL to the clipboard and shows a toast.
  3. Log in as an admin user and verify the "Impersonation" item appears.
  4. Verify that existing navigation items and their expand/collapse behavior remain unchanged.
  5. Run the test suite (yarn test) to ensure no regressions.

Environment variables: None beyond the usual development setup.

Test data: Any user account with a public profile URL.

Checklist

@vercel
Copy link

vercel bot commented Jan 4, 2026

@abhayymishraa is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 4, 2026
@github-actions github-actions bot added ✨ feature New feature or request 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add action‑item support to mobile “More” page and added navigation to refer page". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="apps/web/modules/more/more-page-view.tsx">

<violation number="1" location="apps/web/modules/more/more-page-view.tsx:19">
P2: When `user` is undefined (session loading), `publicPageUrl` will be malformed (e.g., `https://cal.com/undefined`). Consider adding an early return or guard before constructing the URL and rendering the bottom nav items.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

const { data: session } = useSession();
const user = session?.user;
const isAdmin = user?.role === UserPermissionRole.ADMIN;
const publicPageUrl = `${getBookerBaseUrlSync(user?.org?.slug ?? null)}/${
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: When user is undefined (session loading), publicPageUrl will be malformed (e.g., https://cal.com/undefined). Consider adding an early return or guard before constructing the URL and rendering the bottom nav items.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/modules/more/more-page-view.tsx, line 19:

<comment>When `user` is undefined (session loading), `publicPageUrl` will be malformed (e.g., `https://cal.com/undefined`). Consider adding an early return or guard before constructing the URL and rendering the bottom nav items.</comment>

<file context>
@@ -1,17 +1,49 @@
+  const { data: session } = useSession();
+  const user = session?.user;
+  const isAdmin = user?.role === UserPermissionRole.ADMIN;
+  const publicPageUrl = `${getBookerBaseUrlSync(user?.org?.slug ?? null)}/${
+    user?.orgAwareUsername ?? user?.username
+  }`;
</file context>

✅ Addressed in 438ed44

@abhayymishraa abhayymishraa changed the title Add action‑item support to mobile “More” page and hide arrow on copy link button Add action‑item support to mobile “More” page and added navigation to refer page Jan 4, 2026
@abhayymishraa abhayymishraa changed the title Add action‑item support to mobile “More” page and added navigation to refer page feat: Add action‑item support to mobile “More” page and added navigation to refer page Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync ✨ feature New feature or request 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support action items on mobile More page navigation

1 participant