fix: auto-scroll active installed-apps category tab into view on mobile #26414
Conversation
|
@abhayymishraa is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| import HorizontalTabItem from "./HorizontalTabItem"; | ||
|
|
||
| export interface NavTabProps { | ||
| interface NavTabProps { |
There was a problem hiding this comment.
we are not exporting the interface anymore. does this mean we are not using it in any other files?
There was a problem hiding this comment.
I missed that somehow, wanted to make a draft pr somehow made this open pull request!
I will fix it right away
| inline: "center", | ||
| }); | ||
| if (activeHref) lastScrolledActiveHrefRef.current = activeHref; | ||
| }); |
There was a problem hiding this comment.
There is no dependency array here. will it run on every render?
|
@dhairyashiil could you check again! |
dhairyashiil
left a comment
dhairyashiil
left a comment
There was a problem hiding this comment.
LGTM, Thank you for the contribution
dhairyashiil
left a comment
dhairyashiil
left a comment
There was a problem hiding this comment.
@abhayymishraa could you please create the issue you are addressing and link this PR to it?
|
@dhairyashiil i've created the issue and successfully link this pr |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
4 participants
What does this PR do?
Fixes a mobile-only UX issue on Installed Apps category pages (/apps/installed/[category]) where selecting a far-right category (e.g. Other) would navigate correctly but the active tab could remain off-screen in the horizontally scrollable navbar.
This PR adds an opt-in HorizontalTabs behavior to scroll the active tab (aria-current="page") into view, and enables it for the Installed Apps category navbar on mobile only (desktop uses vertical tabs and is unchanged).
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Before:
Screen.Recording.2026-01-03.at.5.23.51.PM.mov
After:
Screen.Recording.2026-01-03.at.5.24.32.PM.mov
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Steps:
Expected:
Checklist