Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken metadata import from platform/types #19986

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

ThyMinimalDev
Copy link
Contributor

Broken import from "@calcom/platform-types/bookings/2024-08-13/inputs/validators/validate-metadata"; api-v2 can't import unbuilt code in prod build

@ThyMinimalDev ThyMinimalDev requested review from a team as code owners March 11, 2025 20:46
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Mar 11, 2025
@dosubot dosubot bot added the 🐛 bug Something isn't working label Mar 11, 2025
METADATA_DOCS,
ValidateMetadata,
} from "@calcom/platform-types/bookings/2024-08-13/inputs/validators/validate-metadata";
import { Metadata, METADATA_DOCS, ValidateMetadata } from "@calcom/platform-types";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need to follow the same approach than for platform libraries

keithwillcode
keithwillcode previously approved these changes Mar 11, 2025
Copy link

graphite-app bot commented Mar 11, 2025

Graphite Automations

"Add ready-for-e2e label" took an action on this PR • (03/11/25)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode disabled auto-merge March 11, 2025 21:15
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:37pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:37pm

@keithwillcode keithwillcode merged commit bc1d73e into main Mar 11, 2025
39 of 40 checks passed
@keithwillcode keithwillcode deleted the fix-platform-types-import-metadata-validator branch March 11, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants