Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove code not needed in defaultResponder #19976

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Mar 11, 2025

What does this PR do?

  • 1 line change—simplify code in defaultResponderForAppDir

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • covered by unit test

@graphite-app graphite-app bot requested a review from a team March 11, 2025 17:06
@hbjORbj hbjORbj changed the title chore: simplify defaultresponderforappdir chore: simplify defaultResponderForAppDir Mar 11, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 11, 2025
@hbjORbj hbjORbj changed the title chore: simplify defaultResponderForAppDir chore: remove code not needed in defaultResponder Mar 11, 2025
@@ -27,7 +27,7 @@ export const defaultResponderForAppDir = <T extends NextResponse | Response = Ne

ok = true;
if (result) {
return result instanceof Response ? result : NextResponse.json(result);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result is already the return value of NextResponse.json() or new Response(), so we shouldn't wrap with another NextResponse.json here

Copy link

graphite-app bot commented Mar 11, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj marked this pull request as draft March 11, 2025 17:18
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 5:28pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 5:28pm

@hbjORbj hbjORbj marked this pull request as ready for review March 11, 2025 17:24
@TusharBhatt1 TusharBhatt1 enabled auto-merge (squash) March 11, 2025 17:26
@TusharBhatt1 TusharBhatt1 merged commit ff5c6de into main Mar 11, 2025
39 of 41 checks passed
@TusharBhatt1 TusharBhatt1 deleted the chore/simplify-defaultResponderForAppDir branch March 11, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants