Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Typescript fixes and updates for bumping ts version to 5.8.2 #19690

Merged
merged 5 commits into from
Mar 5, 2025
Merged

refactor: Typescript fixes and updates for bumping ts version to 5.8.2 #19690

merged 5 commits into from
Mar 5, 2025

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Mar 4, 2025 •
edited
Loading

What does this PR do?

Bumps tRPC package.json typescript to latest

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Typescript fixes and updates for bumping ts version to 5.8.2". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only foundation labels Mar 4, 2025
@emrysal emrysal changed the title Typescript fixes and updates for bumping ts version to 5.8.2 refactor: Typescript fixes and updates for bumping ts version to 5.8.2 Mar 4, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:05am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 0:05am

@emrysal emrysal marked this pull request as ready for review March 4, 2025 12:25
@emrysal emrysal requested a review from a team as a code owner March 4, 2025 12:25
@dosubot dosubot bot added the 💻 refactor label Mar 4, 2025
keithwillcode
keithwillcode requested changes Mar 4, 2025
View reviewed changes
@github-actions github-actions bot marked this pull request as draft March 4, 2025 12:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

E2E results are ready!

@emrysal emrysal requested a review from keithwillcode March 5, 2025 12:00
@emrysal emrysal marked this pull request as ready for review March 5, 2025 12:01
@keithwillcode keithwillcode merged commit 6f62c6a into main Mar 5, 2025
40 of 41 checks passed
@keithwillcode keithwillcode deleted the refactor/trpc-typescript-v5.8.2 branch March 5, 2025 12:17
itsalam pushed a commit to itsalam/cal.com that referenced this pull request Mar 6, 2025
@emrysal @itsalam
refactor: Typescript fixes and updates for bumping ts version to 5.8.2 (
987631b 
calcom#19690)

* Typescript fixes and updates for bumping ts version to 5.8.2

* Different TS versions do see an error, so @ts-ignore'ing

* Attempt this fix for ignoring createDecipher/createCipher fns

* Remove @ts-expect-error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

Assignees
No one assigned
Labels
core area: core, team members only foundation ready-for-e2e 💻 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emrysal @keithwillcode