fix: scheduleId to work on PATCH event type host assignment via api v1 #19546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shpadoinkle is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
api
3 tasks
Shpadoinkle
changed the title
Shpadoinkle
force-pushed
the
fix/scheduleid-on-event-type-hosts-api-v1
branch
from
f946426 to
ea3547c
Compare
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/26/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (02/26/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (03/03/25)1 label was added to this PR based on Keith Williams's automation. |
retrogtx
reviewed
Feb 26, 2025
@retrogtx this pr is separate, and does not require the other pr to be merged first. |
retrogtx
approved these changes
Feb 27, 2025
ThyMinimalDev
approved these changes
Mar 3, 2025
E2E results are ready! |
itsalam
pushed a commit
to itsalam/cal.com
that referenced
this pull request
Mar 6, 2025
calcom#19546) Co-authored-by: amrit <iamamrit27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates to api V1:
hostsvia the apiMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Using the calcom frontend, set up a host on a Round robin using a custom schedule other than their default.
If you use the patch endpoint to set a host, passing in
scheduleIdusing the current api is ignored. and the hosts will use their default scheduleIf you use the patch endpoint using this change, then passing in a scheduleId will save it as expected