feat: delete past bookings

[hp77-creator]

What does this PR do?

I have added two options for the user to delete past bookings.

They can delete individual bookings like this:

Or they can delete all the bookings in one go using the main button:

• Fixes [CAL-5114] Delete the booking history of past or canceled meetings #18787
• Fixes CAL-5114

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

1. Login with pro@example.com
2. Go to bookings
3. Click on delete button

/claim #18787

[vercel]

@hp77-creator is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Feature delete past meeting". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/05/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/05/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/07/25)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (02/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

[hp77-creator]

@jublevy @PeerRich please review the PR, I have added the all delete button as well for past booking, lmk if there is any changes required.

[retrogtx]

Hi @hp77-creator, thanks for your PR!
Can you please add a short loom video for the same? Meanwhile I will test your changes out locally :D

[retrogtx]

from the original issue, can you implement this?

edit: this is a separate thing, needs approval - nevermind

[retrogtx]

Got it running locally, the button shows up even though I have zero bookings in this account. Please make it such that it appears only if I have at least 1 booking in the past.

[hp77-creator]

from the original issue, can you implement this?

edit: this is a separate thing, needs approval - nevermind

Yes, I thought so too, this needs a separate development. It is not trivial as this feature.

[hp77-creator]

Got it running locally, the button shows up even though I have zero bookings in this account. Please make it such that it appears only if I have at least 1 booking in the past.

will do this change

[hp77-creator]

Screen.Recording.2025-02-06.at.9.34.55.PM.mov

@retrogtx added the change and the vid

[retrogtx]

this works, lgtm

[github-actions]

E2E results are ready!

• Workflow #47369.1 latest results

[keithwillcode]

Only marking as requested changes to ensure this gets a review from Foundation before merge due to the high-risk nature of this. @emrysal @zomars @ThyMinimalDev @eunjae-lee

[keithwillcode]

This code cannot be merged without automated tests verifying:

• Deleting 1 booking only deletes the 1 record
• Deleting multiple bookings deletes only the exact bookings it should
• I cannot delete other bookings I don't have permission to delete

[hp77-creator]

Thanks @keithwillcode
I will add the tests.

[retrogtx]

Thanks @keithwillcode I will add the tests.

hey @hp77-creator
are you working on tests?

[hp77-creator]

I am working on it @retrogtx
Was confused yesterday where to add these cases?
And do I need to add router tests or e2e UI tests?

[retrogtx]

I am working on it @retrogtx Was confused yesterday where to add these cases? And do I need to add router tests or e2e UI tests?

Add router tests as we do not wish to delete something that is unnecessary as that will be dangerous
There is a test folder in app/web/test/lib

An example for the same: #19071

Thank you

[hp77-creator]

I was checking the vitest.workspace.ts file @retrogtx
It seems the directory you mention isn't added there, are tests in those directory run?
I was hoping to also run them in my system before pushing them, how can I run them locally? I checked vitess docs, I see that we trigger them using scripts in package.json only but I didn't find any script command for the directory that you mentioned. Maybe I missed something, can you help?

[retrogtx]

I was checking the vitest.workspace.ts file @retrogtx It seems the directory you mention isn't added there, are tests in those directory run? I was hoping to also run them in my system before pushing them, how can I run them locally? I checked vitess docs, I see that we trigger them using scripts in package.json only but I didn't find any script command for the directory that you mentioned. Maybe I missed something, can you help?

hey, the tests in that directory is just run. you can trigger it yourself by writing npx vitest yourfilepath/.../.. <- this helps trigger only the one test file

[hp77-creator]

indeed we can, I was confused because I thought this needs to go into suite as well, i will follow what you have mentioned. Thanks.

[hp77-creator]

@keithwillcode Thanks for the change request of adding test, It made me add check for unauthorized user, I have added tests, @retrogtx you may review, Thanks for your patience.
Here are the test results:

[retrogtx]

thank you for the PR @hp77-creator

since this deals with risky parts (like permanently deleting) this will take some time!