-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get org ooo entries and filters/sort #18645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
area: core, team members only
platform
Anything related to our platform plan
labels
Jan 14, 2025
dosubot
bot
added
api
area: API, enterprise API, access token, OAuth
organizations
area: organizations, orgs
✨ feature
New feature or request
labels
Jan 14, 2025
Graphite Automations"Add platform team as reviewer" took an action on this PR • (01/14/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/14/25)1 label was added to this PR based on Keith Williams's automation. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
CarinaWolli
previously approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 🙏
apps/api/v2/src/modules/organizations/controllers/users/ooo/organizations-users-ooo.e2e-spec.ts
Outdated
Show resolved
Hide resolved
CarinaWolli
approved these changes
Jan 14, 2025
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
area: API, enterprise API, access token, OAuth
core
area: core, team members only
✨ feature
New feature or request
organizations
area: organizations, orgs
platform
Anything related to our platform plan
ready-for-e2e
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added endpoint to get all ooo entries of users within your org, with sort and filter by email
same sorting for /users/:userId/ooo endpoint
also increased maximum size of page for get all org user endpoint to accommodate orgs with thousands of users
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn test:e2e organizations-users-ooo.e2e-spec.ts