feat: sound on browser push notification #18548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
changed the title
Udit-takkar
commented
Jan 16, 2025
|
|
||
| import { useEffect, useRef } from "react"; | ||
|
|
||
| export function NotificationSoundHandler() { |
There was a problem hiding this comment.
This is required to load the audio as soon as user interacts with our site.
Udit-takkar
commented
Jan 16, 2025
| }; | ||
| self.registration.showNotification(notification.title, options); | ||
| }); | ||
| const title = notificationData.title || "New Cal.com Notification"; |
There was a problem hiding this comment.
The service worker would trigger notification and send message to play sound if notification type is instant meetings
Udit-takkar
commented
Jan 16, 2025
Comment on lines
-199
to
-214
| {/* TODO: temporary hide push notifications {props.heading === "Bookings" && buttonToShow && ( | ||
| <Button | ||
| color="primary" | ||
| onClick={buttonToShow === ButtonState.ALLOW ? enableNotifications : disableNotifications} | ||
| loading={isLoading} | ||
| disabled={buttonToShow === ButtonState.DENIED} | ||
| tooltipSide="bottom" | ||
| tooltip={ | ||
| buttonToShow === ButtonState.DENIED ? t("you_have_denied_notifications") : undefined | ||
| }> | ||
| {t( | ||
| buttonToShow === ButtonState.DISABLE | ||
| ? "disable_browser_notifications" | ||
| : "allow_browser_notifications" | ||
| )} | ||
| </Button> | ||
| )} */} |
There was a problem hiding this comment.
I created a new page for this setting. I don't think we should display this in /bookings page like before
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/16/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (03/08/25)1 label was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
ui
|
This PR is being marked as stale due to inactivity. |
|
This PR is being marked as stale due to inactivity. |
|
Let me fix the conflicts |
Udit-takkar
force-pushed
the
feat/ringtone
branch
from
00d1295 to
45eaeb1
Compare
github-actions
bot
added
High priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Browser push notifications would only work with https url so use this command ngrok http 3000
Go to /settings/my-account/push-notifications and click on allow notification and make sure you have enabled notification for your browser in system settings.
Create an org team event type with instant booking enabled
Go to booking page and click on 'Connect Now' modal and book meeting.
You should have gotten a push notification with a ringing sound