Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve prisma exception filter messages #18227

Merged
merged 2 commits into from
Dec 17, 2024
Merged

chore: improve prisma exception filter messages #18227

merged 2 commits into from
Dec 17, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Dec 17, 2024 •
edited
Loading

What does this PR do?

Improve Prisma exception filter to return readable message for known errors

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:11am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:11am

@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Dec 17, 2024
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Dec 17, 2024
@graphite-app graphite-app bot requested a review from a team December 17, 2024 08:09
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 17, 2024 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (12/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/17/24)

1 label was added to this PR based on Keith Williams's automation.

supalarry
supalarry previously approved these changes Dec 17, 2024
View reviewed changes
@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) December 17, 2024 08:11
@ThyMinimalDev ThyMinimalDev merged commit a0ce42e into main Dec 17, 2024
37 of 38 checks passed
@ThyMinimalDev ThyMinimalDev deleted the improve-prisma-exception-filter-known-errors-handling branch December 17, 2024 08:40
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-brydon sean-brydon sean-brydon approved these changes

@supalarry supalarry Awaiting requested review from supalarry

Assignees
No one assigned
Labels
core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThyMinimalDev @supalarry @sean-brydon @keithwillcode