fix: trpc/react-query — only one query client should exist #18179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/13/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
commented
Dec 13, 2024
| const [queryClient] = useState( | ||
| () => | ||
| new QueryClient({ | ||
| defaultOptions: { queries: { staleTime: 5000 } }, | ||
| // these configurations are copied from "packages/trpc/react/trpc.ts" |
There was a problem hiding this comment.
as the comment says
| @@ -1,11 +1,16 @@ | |||
| import { type DehydratedState, QueryClient, QueryClientProvider } from "@tanstack/react-query"; | |||
| import { HydrateClient } from "app/_trpc/HydrateClient"; | |||
| "use client"; | |||
There was a problem hiding this comment.
this is a client component. we use useState.
| @@ -112,7 +113,7 @@ export default async function RootLayout({ children }: { children: React.ReactNo | |||
| }} | |||
| /> | |||
| )} | |||
| {children} | |||
| <TrpcProvider>{children}</TrpcProvider> | |||
There was a problem hiding this comment.
We need to call this provider only once and hence it needs to be in this file
hbjORbj
requested review from
emrysal and
zomars
and removed request for
a team
3 tasks
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)