Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve getAllUserBooking filter by teamIds #18171

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: improve getAllUserBooking filter by teamIds #18171

merged 2 commits into from
Dec 13, 2024
+2 −10

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Dec 13, 2024 •
edited
Loading

What does this PR do?

attempting to improve query generated by Prisma by simplifying the teamId filter

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Dec 13, 2024
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 13, 2024
@graphite-app graphite-app bot requested a review from a team December 13, 2024 17:49
@ThyMinimalDev ThyMinimalDev changed the title fix: improve getAllUserBooking filted by teamIds fix: improve getAllUserBooking filter by teamIds Dec 13, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 13, 2024 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (12/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/13/24)

1 label was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 5:52pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 5:52pm

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@ThyMinimalDev ThyMinimalDev merged commit 18a0eb9 into main Dec 13, 2024
40 of 59 checks passed
@ThyMinimalDev ThyMinimalDev deleted the improve-get-all-user-booking-by-team branch December 13, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

@emrysal emrysal Awaiting requested review from emrysal

@keithwillcode keithwillcode Awaiting requested review from keithwillcode

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThyMinimalDev @zomars @keithwillcode