Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade actions/upload-artifact to v4 #18160

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: Upgrade actions/upload-artifact to v4 #18160

merged 1 commit into from
Dec 13, 2024

Conversation

keithwillcode
Copy link
Contributor

What does this PR do?

We had 1 instance of actions/upload-artifact still using v3 which is going out of support in January.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • After this is merged to main (testing it beforehand is cumbersome and not worth the effort imo), ensure that requesting changes on a PR puts the PR back into draft

@keithwillcode keithwillcode added this to the v4.8 milestone Dec 13, 2024
@keithwillcode keithwillcode self-assigned this Dec 13, 2024
@graphite-app graphite-app bot requested a review from a team December 13, 2024 11:10
@keithwillcode keithwillcode added core area: core, team members only foundation labels Dec 13, 2024
@dosubot dosubot bot added the ci area: CI, DX, pipeline, github actions label Dec 13, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) December 13, 2024 11:11
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 13, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (12/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/13/24)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode merged commit 1ab4ec9 into main Dec 13, 2024
41 of 62 checks passed
@keithwillcode keithwillcode deleted the chore/upgrade-github-actions branch December 13, 2024 11:32
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

@sean-brydon sean-brydon sean-brydon approved these changes

Assignees

@keithwillcode keithwillcode

Labels
ci area: CI, DX, pipeline, github actions core area: core, team members only foundation ready-for-e2e
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@keithwillcode @Udit-takkar @sean-brydon