chore: Upgrade actions/upload-artifact to v4

[keithwillcode]

What does this PR do?

We had 1 instance of actions/upload-artifact still using v3 which is going out of support in January.

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• After this is merged to main (testing it beforehand is cumbersome and not worth the effort imo), ensure that requesting changes on a PR puts the PR back into draft

[graphite-app]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (12/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/13/24)

1 label was added to this PR based on Keith Williams's automation.

[github-actions]

E2E results are ready!

• Workflow #41192.1 latest results