Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Node alpine libssl symlink fix #18127

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Dec 11, 2024

What does this PR do?

Provides a better fix; in the latest version of libssl on Alpine Linux libssl has moved from /usr to /usr/lib. An open PR exists @ Prisma to fix this going forward but in the mean time we can symlink this as a semi-permanent safe solution.

The benefit of not locking the version is mitigation for future libssl (or other) zerodays. A Symlink solution is preferred.

prisma/prisma#25824

@graphite-app graphite-app bot requested a review from a team December 11, 2024 23:31
@keithwillcode keithwillcode added core area: core, team members only foundation labels Dec 11, 2024
@emrysal emrysal changed the title Node alpine libssl symlink fix build: Node alpine libssl symlink fix Dec 11, 2024
@calcom calcom deleted a comment from github-actions bot Dec 11, 2024
Copy link

graphite-app bot commented Dec 11, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (12/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/12/24)

1 label was added to this PR based on Keith Williams's automation.

@zomars zomars enabled auto-merge (squash) December 12, 2024 00:15
@zomars zomars merged commit de0de64 into main Dec 12, 2024
59 of 81 checks passed
@zomars zomars deleted the unlock-node-alpine-with-symlink branch December 12, 2024 00:39
Copy link
Contributor

E2E results are ready!

@dosubot dosubot bot added the docker label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants