fix: prevent infinite rerendering of DataTable #18087
Merged
+39
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
commented
Dec 10, 2024
Comment on lines
+5
to
+25
| export const useFetchMoreOnBottomReached = ({ | ||
| tableContainerRef, | ||
| hasNextPage, | ||
| fetchNextPage, | ||
| isFetching, | ||
| }: { | ||
| tableContainerRef: React.RefObject<HTMLDivElement>; | ||
| hasNextPage: boolean; | ||
| fetchNextPage: () => void; | ||
| isFetching: boolean; | ||
| }) => { | ||
| const fetchMoreOnBottomReached = useCallback( | ||
| (containerRefElement?: HTMLDivElement | null) => { | ||
| if (containerRefElement) { | ||
| const { scrollHeight, scrollTop, clientHeight } = containerRefElement; | ||
| if (scrollHeight - scrollTop - clientHeight < 300 && !isFetching && totalFetched < totalDBRowCount) { | ||
| if (scrollHeight - scrollTop - clientHeight < 300 && !isFetching && hasNextPage) { | ||
| fetchNextPage(); | ||
| } | ||
| } | ||
| }, | ||
| [fetchNextPage, isFetching, totalFetched, totalDBRowCount] | ||
| [fetchNextPage, isFetching] |
There was a problem hiding this comment.
We relied on totalFetched and totalDBRowCount. However, when filters are applied, we cannot.
For example, let's say the filter result is only a single row. Then it's like:
totalFetched === 1
totalDBRowCount === 23424 // whatever the total db row count
Then this if condition is true, so it tries to fetch the next page even though there is no next page at all. So from now on, we use hasNextPage variable instead.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/10/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/11/24)1 label was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
UserListTableis infinitely rendered when a filter value is set. This PR fixes it by fixing the implementation ofuseFetchMoreOnBottomReached.Screenshot.2024-12-10.at.12.59.18.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
in
Checklist