fix: No option to install/disconnect app from app detail page #17997
Conversation
|
@asadath1395 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
app-store
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/04/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/04/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/01/25)1 label was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…hub.com/asadath1395/cal.com into fix-install-disconnect-app-details-page
|
@keithwillcode Can you please assign someone to review this? Thanks |
|
@PeerRich Can we get this merged? |
hey the E2E tests are failing on this |
|
@asadath1395 are you still working on this , tests are failing |
it's the E2E failure I think, Anik is working on this made a PR for the same yesterday |
|
@anikdhabal Are you able to reproduce the failing test locally? Since you fixed something related to analytics app store installation recently, I can't seem to reproduce that, it works fine in my machine. |
apps/web/components/apps/AppPage.tsx
Outdated
| const appInstalledForAllTargets = | ||
| availableForTeams && Array.isArray(data?.userAdminTeams) && data.userAdminTeams.length > 0 |
There was a problem hiding this comment.
There was an actual bug. It was always true in cases where data.userAdminTeams = [], and availableForTeams && data?.userAdminTeams was also true for that. That's why the install button was not visible.
…#17997) * fix: No option to install/disconnect app from app detail page * Fix types * fix: Install button showing up even after it is installed for all targers * chore: Simplified installOrDisconnectAppButton making it easy to read --------- Co-authored-by: Hariom <hariombalhara@gmail.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com>
What does this PR do?
No option to install/disconnect app from app detail page
It fixes only the issue-2 mentioned in the linked ticket -- Hariom
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
https://www.loom.com/share/49e1050b7e1e42e9af6e669b953b4118?sid=0807e556-61a0-4faa-99ea-d4ce9795b8a0