Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add assignment reason to routing insights #17984

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat: add assignment reason to routing insights #17984

merged 4 commits into from
Dec 4, 2024

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Dec 3, 2024 •
edited
Loading

What does this PR do?

Adds assignment reason to insights table and the csv export
CleanShot 2024-12-04 at 07 58 12

How should this be tested?

  • Setup a routing form
  • Setup sales force
  • Test a routing form
  • Check reason in table and csv

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 8:04am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 8:04am

@sean-brydon sean-brydon marked this pull request as draft December 3, 2024 19:03
@graphite-app graphite-app bot requested a review from a team December 3, 2024 19:03
@dosubot dosubot bot added insights area: insights, analytics routing-forms area: routing forms, routing, forms ✨ feature New feature or request labels Dec 3, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 3, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 3, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/03/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/04/24)

1 label was added to this PR based on Keith Williams's automation.

@sean-brydon sean-brydon marked this pull request as ready for review December 4, 2024 07:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

E2E results are ready!

@sean-brydon sean-brydon merged commit 982a715 into main Dec 4, 2024
59 of 60 checks passed
@sean-brydon sean-brydon deleted the feat/add-routing-reason branch December 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

@joeauyeung joeauyeung Awaiting requested review from joeauyeung

Assignees
No one assigned
Labels
consumer core area: core, team members only ✨ feature New feature or request insights area: insights, analytics ready-for-e2e routing-forms area: routing forms, routing, forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sean-brydon @PeerRich @keithwillcode