Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting insights table for booking status #17982

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

sean-brydon
Copy link
Member

What does this PR do?

CleanShot 2024-12-03 at 18 16 37@2x

We now sort by booking status rather than the booking id which was default

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team December 3, 2024 18:18
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 3, 2024
@dosubot dosubot bot added insights area: insights, analytics 🐛 bug Something isn't working labels Dec 3, 2024
Copy link

graphite-app bot commented Dec 3, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/03/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/03/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 8:56am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 8:56am

PeerRich
PeerRich previously approved these changes Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

E2E results are ready!

@PeerRich PeerRich merged commit 950879b into main Dec 9, 2024
38 checks passed
@PeerRich PeerRich deleted the fix/sorting-insights-table branch December 9, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working consumer core area: core, team members only insights area: insights, analytics ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants