Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract trpc and react-awesome-query-builder from atoms #17801

Merged
merged 11 commits into from
Nov 23, 2024
Merged

fix: extract trpc and react-awesome-query-builder from atoms #17801

merged 11 commits into from
Nov 23, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Nov 22, 2024 •
edited
Loading

What does this PR do?

Atoms were not working anymore after introduction of react-awesome-query-builder in the codebase and adding session to eventSetupTab

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A -I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@dosubot dosubot bot added event-types area: event types, event-types platform Anything related to our platform plan labels Nov 22, 2024
@graphite-app graphite-app bot requested a review from a team November 22, 2024 14:35
@keithwillcode keithwillcode added the core area: core, team members only label Nov 22, 2024
@ThyMinimalDev ThyMinimalDev changed the title chore: fix atoms not working with react-awesome-query-builder fix: extract trpc and react-awesome-query-builder from atoms Nov 22, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 22, 2024 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (11/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/22/24)

1 label was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 0:08am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 0:08am

@supalarry supalarry self-requested a review November 22, 2024 17:29
supalarry
supalarry previously approved these changes Nov 22, 2024
View reviewed changes
@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) November 22, 2024 19:20
@socket-security Socket Security
Copy link

socket-security bot commented Nov 22, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@ThyMinimalDev ThyMinimalDev merged commit c2a3d8b into main Nov 23, 2024
37 checks passed
@ThyMinimalDev ThyMinimalDev deleted the fix-platform-event-types-segment branch November 23, 2024 12:29
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryukemeister Ryukemeister Ryukemeister approved these changes

@supalarry supalarry supalarry left review comments

Assignees
No one assigned
Labels
core area: core, team members only event-types area: event types, event-types platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThyMinimalDev @supalarry @Ryukemeister @keithwillcode