feat: remove 2 steps from the onboarding flow for google signups #17787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/21/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
hbjORbj
commented
Nov 22, 2024
| stepLabel: (currentStep: number, totalSteps: number) => `Test Step ${currentStep} of ${totalSteps}`, | ||
| disableNavigation: undefined, |
There was a problem hiding this comment.
fixes type error that existed in this test file
3 tasks
auto-merge was automatically disabled
November 24, 2024 05:46
Pull request was converted to draft
eunjae-lee
approved these changes
Dec 9, 2024
| const EXTRA_STEPS = ["connected-calendar", "connected-video"] as const; | ||
| type StepType = (typeof BASE_STEPS)[number] | (typeof EXTRA_STEPS)[number]; | ||
|
|
||
| const getStepsAndHeadersForUser = (identityProvider: IdentityProvider, t: TFunction) => { |
There was a problem hiding this comment.
nit: this looks like a hook, instead of a function.
There was a problem hiding this comment.
Thanks, will address this in a separate PR!
| }); | ||
| testOnboarding(IdentityProvider.GOOGLE); | ||
| testOnboarding(IdentityProvider.CAL); | ||
| testOnboarding(IdentityProvider.SAML); |
There was a problem hiding this comment.
q: do we need to await Promise.all? or no need?
There was a problem hiding this comment.
Good Q, let me play with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?