chore: Make URLs for terms and privacy policy customizable via .env vars #16350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CodeShakingSheep is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
bot
added
booking-page
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/25/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (08/25/24)1 label was added to this PR based on Keith Williams's automation. |
anikdhabal
reviewed
Aug 25, 2024
anikdhabal
reviewed
Aug 25, 2024
anikdhabal
requested changes
Aug 25, 2024
Contributor
anikdhabal
left a comment
anikdhabal
left a comment
There was a problem hiding this comment.
Nice works @CodeShakingSheep , left commnets
Contributor
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows self-hosted instances to set custom URLs for Terms and Privacy Policy by introducing two new
.envvarsNEXT_PUBLIC_WEBSITE_PRIVACY_POLICY_URLandNEXT_PUBLIC_WEBSITE_TERMS_URL. The custom URLs will then be displayed on the signup page as well as on the event booking form.Signup page before
This was set to
${WEBSITE_URL}/terms(note the URL in the bottom left corner of the screenshot). While this page exists for the Cal.com platform it doesn't exist in the case of self-hosted instances which just led to a HTTP 404 error. See screenshot for terms URL (same applied to the privacy policy URL).Signup page after (with custom URLs)
Note the link to custom terms in the bottom left corner when hovering over the terms link. Same applies to privacy policy link.
Signup page after (without custom URLs - fall back to Cal.com terms and privacy policy)
Note the link to Cal.com's terms in the bottom left corner when hovering over the terms link. Same applies to privacy policy link.
Event booking form before
There was no reference to terms and privacy policy at all (was removed in #13966).
Event booking form after (with custom URLs)
Note the link to custom terms in the bottom left corner when hovering over the terms link. Same applies to privacy policy link.
Event booking form after (without custom URLs - fall back to Cal.com terms and privacy policy)
Note the link to Cal.com's terms in the bottom left corner when hovering over the terms link. Same applies to privacy policy link.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Set the
.envvarsNEXT_PUBLIC_WEBSITE_PRIVACY_POLICY_URLandNEXT_PUBLIC_WEBSITE_TERMS_URLto any URL. Then visitOn both pages hover over the
TermsandPrivacylinks and verify that they point to the URLs you set in.env(NEXT_PUBLIC_WEBSITE_PRIVACY_POLICY_URLandNEXT_PUBLIC_WEBSITE_TERMS_URL).