Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes e2e retries and videos #1537

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Removes e2e retries and videos #1537

merged 2 commits into from
Jan 17, 2022

Conversation

zomars
Copy link
Member

@zomars zomars commented Jan 17, 2022

What does this PR do?

  • Retries aren't being useful in our context and are just delaying tests
  • Also since we can use traces to debug, we don't need to save videos anymore.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cal/calendso/2Ac6gqKnnvug6WUKmiofpBKqDmF1
✅ Preview: https://calendso-git-fix-e2e-retries-and-videos-cal.vercel.app

@zomars zomars requested a review from emrysal January 17, 2022 20:11
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, never looked at them. Retries may make sense though

@zomars
Copy link
Member Author

zomars commented Jan 17, 2022

Agree, never looked at them. Retries may make sense though

Many of these tests aren't designed to be "retry-able". For example the Stripe one always expects for the integration to be disconnected. So if it connects on the first try and the paid booking fail, it will retry and since it's already connected it will time out. We can decide later if we should address that or just disable retries for now.

@vercel vercel bot temporarily deployed to Preview January 17, 2022 20:19 Inactive
@zomars zomars added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Jan 17, 2022
@emrysal emrysal merged commit 038ea33 into main Jan 17, 2022
@emrysal emrysal deleted the fix/e2e-retries-and-videos branch January 17, 2022 20:23
@emrysal
Copy link
Contributor

emrysal commented Jan 17, 2022

I think with the recent fail on #1488 - retries weren't run, that was definitely a temporary problem and the reason @KATT put the retry there in the first place is to fix those "Yeah, playwright is just weird, sometimes" cases.

So, IMO, we should fix Stripe and reimplement retries.

@zomars
Copy link
Member Author

zomars commented Jan 17, 2022

Let's hope playwright isn't that weird anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants