Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zomars/cal 748 paid bookings are failing #1335

Merged
merged 30 commits into from
Dec 17, 2021

Conversation

zomars
Copy link
Member

@zomars zomars commented Dec 16, 2021

What does this PR do?

  • Adds tests for adding a Stripe integration
  • Adds test for booking a paid event type
  • Adds default paid event type to pro user in seeder
  • Skips Stripe tests if Stripe is not installed (for self-hosted)
  • Adds visual indicator for unpaid bookings in /bookings
  • Stripe Card Element auto-updates locale based on viewer locale
  • Fixes missing booking relation in payment

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Add a Stripe Connect account in Integrations
  • Add a price to a event type
  • Book that event type
  • Booking should appear as unpaid and unconfirmed
  • Pay that booking
  • Booking should appear as paid and confirmed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@linear
Copy link

linear bot commented Dec 16, 2021

CAL-748 Paid Bookings are failing

It seems that the eventManager refactoring is making Stripe Connect Webhook to crash. I'm investigating...

Reported by zomars.

@vercel
Copy link

vercel bot commented Dec 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cal/calendso/3zmxTFZzAUEe9ndsApbuiFJZEkRA
✅ Preview: https://calendso-git-zomars-cal-748-paid-bookings-are-failing-cal.vercel.app

@zomars zomars added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Dec 16, 2021
@vercel vercel bot temporarily deployed to Preview December 16, 2021 20:44 Inactive
@vercel vercel bot temporarily deployed to Preview December 16, 2021 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview December 16, 2021 22:21 Inactive
@zomars zomars marked this pull request as ready for review December 16, 2021 22:29
@zomars zomars requested review from emrysal and jamiepine December 16, 2021 22:29
@zomars zomars enabled auto-merge (squash) December 16, 2021 22:30
@vercel vercel bot temporarily deployed to Preview December 16, 2021 22:38 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 00:04 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 00:13 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 00:17 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 01:02 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 13:45 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 15:14 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 15:20 Inactive
Comment on lines +15 to +21
CALENDSO_ENCRYPTION_KEY: ${{ secrets.CI_CALENDSO_ENCRYPTION_KEY }}
NEXT_PUBLIC_STRIPE_PUBLIC_KEY: ${{ secrets.CI_NEXT_PUBLIC_STRIPE_PUBLIC_KEY }}
STRIPE_PRIVATE_KEY: ${{ secrets.CI_STRIPE_PRIVATE_KEY }}
STRIPE_CLIENT_ID: ${{ secrets.CI_STRIPE_CLIENT_ID }}
STRIPE_WEBHOOK_SECRET: ${{ secrets.CI_STRIPE_WEBHOOK_SECRET }}
PAYMENT_FEE_PERCENTAGE: 0.005
PAYMENT_FEE_FIXED: 10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already added to GitHub

@zomars zomars merged commit 2110358 into main Dec 17, 2021
@zomars zomars deleted the zomars/cal-748-paid-bookings-are-failing branch December 17, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants