Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Check the webhook event tab and your funtionalities #12433

Merged
merged 21 commits into from
Jan 25, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Nov 19, 2023

DEMO

Fixes #13180

image

Copy link
Contributor Author

gitstart-app bot commented Nov 19, 2023

This PR is estimated to cost between 10 and 20 credits.
🟡 By merging this PR you agree to this estimate. If you disagree, click here.

Copy link

vercel bot commented Nov 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 3:32am
calcom-web-canary 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 3:32am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 3:32am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 3:32am
cal ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 3:32am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 3:32am
qa ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 3:32am
ui ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 3:32am

Copy link
Contributor

github-actions bot commented Nov 19, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Nov 19, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Nov 19, 2023

Current Playwright Test Results Summary

✅ 415 Passing - ⚠️ 16 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/23/2024 03:36:50am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: d320ce3

Started: 01/23/2024 03:28:24am UTC

⚠️ Flakes

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Checkbox Group required and Address required
Retry 2Retry 1Initial Attempt
0% (0) 0 / 288 runs
failed over last 7 days
1.74% (5) 5 / 288 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Multi email Question Checkbox Group required and Multi email required
Retry 1Initial Attempt
0% (0) 0 / 266 runs
failed over last 7 days
2.26% (6) 6 / 266 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
35.38% (23) 23 / 65 runs
failed over last 7 days
38.46% (25) 25 / 65 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Number Question Phone and Number required
Retry 1Initial Attempt
0.30% (1) 1 / 334 run
failed over last 7 days
2.99% (10) 10 / 334 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address and Multi email not required
Retry 1Initial Attempt
1.25% (4) 4 / 320 runs
failed over last 7 days
2.19% (7) 7 / 320 runs
flaked over last 7 days

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Non-Organization Event Types Page open Embed Dialog and choose floating-popup for First Event Type
Retry 1Initial Attempt
0% (0) 0 / 351 runs
failed over last 7 days
12.54% (44) 44 / 351 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.42% (5) 5 / 351 runs
failed over last 7 days
55.84% (196) 196 / 351 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-59.81% (-125) -125 / 209 runs
failed over last 7 days
106.70% (223) 223 / 209 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-66.18% (-137) -137 / 207 runs
failed over last 7 days
85.02% (176) 176 / 207 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-65.22% (-135) -135 / 207 runs
failed over last 7 days
101.93% (211) 211 / 207 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-65.70% (-136) -136 / 207 runs
failed over last 7 days
65.70% (136) 136 / 207 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-65.70% (-136) -136 / 207 runs
failed over last 7 days
65.70% (136) 136 / 207 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-65.70% (-136) -136 / 207 runs
failed over last 7 days
65.70% (136) 136 / 207 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-66.02% (-136) -136 / 206 runs
failed over last 7 days
66.02% (136) 136 / 206 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.86% (3) 3 / 347 runs
failed over last 7 days
39.19% (136) 136 / 347 runs
flaked over last 7 days

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox group Question Multiple Email and checkbox group not required
Retry 1Initial Attempt
1.99% (7) 7 / 351 runs
failed over last 7 days
4.56% (16) 16 / 351 runs
flaked over last 7 days

View Detailed Build Results


@gitstart-calcom
Copy link
Contributor

On this PR we are performing the following steps:

  1. Add webhooks to an event type
  2. Reproduce the steps to trigger the webhook event
  3. Check if the payload from the webhook matches the expected result

The test followed what was done on webhook.e2e

Copy link
Contributor

github-actions bot commented Dec 8, 2023

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 8, 2023
@keithwillcode keithwillcode added this to the v3.8 milestone Jan 11, 2024
@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 11, 2024
@@ -0,0 +1,233 @@
import { expect } from "@playwright/test";
Copy link
Member

@hariombalhara hariombalhara Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like webhook.e2e.ts is the right place for these tests. That file verifies settings webhooks flow and it verifies the event-type webhook flow.

We will have a single place for all types of webhook tests.

They share a lot of logic as well.

webhookReceiver.close();
});

test("Booking canceled", async ({ bookingPage }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test("Booking canceled", async ({ bookingPage }) => {
test("Booking cancelled", async ({ bookingPage }) => {

Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitstart-calcom 🙏 The tests are failing right now.

@gitstart-app gitstart-app bot marked this pull request as draft January 20, 2024 06:00
Copy link
Contributor Author

gitstart-app bot commented Jan 23, 2024

This PR is estimated to cost between 10 and 20 credits.
🟡 By merging this PR you agree to this estimate. If you disagree, click here.

@keithwillcode
Copy link
Contributor

@gitstart-calcom i see the tests are passing now. Is this ready to be pulled out of draft?

@gitstart-calcom gitstart-calcom marked this pull request as ready for review January 25, 2024 18:46
@gitstart-calcom
Copy link
Contributor

Hi @keithwillcode , it's ready for review! Thanks for the reminder 😄

@keithwillcode keithwillcode enabled auto-merge (squash) January 25, 2024 18:49
@keithwillcode keithwillcode merged commit 9db9204 into main Jan 25, 2024
@keithwillcode keithwillcode deleted the teste2e-webhook branch January 25, 2024 18:50
emrysal added a commit that referenced this pull request Feb 28, 2024
Udit-takkar added a commit that referenced this pull request Feb 28, 2024
* fix: Test flakiness due to unfilled name/email

* Better toast-success checks

* Revert "test: Create E2E tests for bookings with custom/required Phone + other questions (#11502)"

This reverts commit 614741d.

* Revert "test: Create E2E tests for bookings with custom/required Multiple Emails + other questions  (teste2e-multipleEmailQuestion) (#11565)"

This reverts commit d1d50b0.

* Revert "test: Create E2E tests for bookings with custom/required Long Text + other questions (teste2e-longTextQuestion) (#11559)"

This reverts commit 96810b5.

* Revert "test: Check the webhook event tab and your funtionalities (#12433)"

This reverts commit 9db9204.

* Re-instate regularBookings

* Fixtures used by other tests

* Removed dead code from regularBookings.ts

---------

Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2915] test: Check the webhook event tab and your funtionalities
4 participants