Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing avatar for non-migrated users on team booking page #11977

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Oct 18, 2023

What does this PR do?

More details https://threads.com/thread/34542069818/34542958382?s=o3wzwcB72cJdWsJyxNvd8o

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Use /moveToOrg endpoint to move a user to an org along with his team
  • Go to the team booking page and notice that the user who was moved has the correct avatar but who wasn't moved doesn't have the avatar. This PR fixes the issue.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 3:42pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 3:42pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 3:42pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 3:42pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 3:42pm
qa ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 3:42pm
ui ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 3:42pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Oct 18, 2023

Current Playwright Test Results Summary

✅ 162 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/18/2023 03:43:03pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 93856eb

Started: 10/18/2023 03:40:42pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
9.09% (30) 30 / 330 runs
failed over last 7 days
89.39% (295) 295 / 330 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
3.02% (10) 10 / 331 runs
failed over last 7 days
46.83% (155) 155 / 331 runs
flaked over last 7 days

📄   apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Insights should test download button
Retry 2Retry 1Initial Attempt
0% (0) 0 / 102 runs
failed over last 7 days
3.92% (4) 4 / 102 runs
flaked over last 7 days

View Detailed Build Results


@hariombalhara hariombalhara merged commit efc3e86 into main Oct 19, 2023
@hariombalhara hariombalhara deleted the fix/missing-avatars-org-migration branch October 19, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants