fix: Add /embed route for booking/[uid] #11976
Conversation
hariombalhara
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
| @@ -1100,7 +1100,7 @@ export async function getServerSideProps(context: GetServerSidePropsContext) { | |||
| if (!bookingInfoRaw) { | |||
| return { | |||
| notFound: true, | |||
| }; | |||
| } as const; | |||
There was a problem hiding this comment.
as const is required for withEmbedSsr to have correct types.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 New Page AddedThe following page was added to the bundle from the code in this PR:
One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/18/2023 06:42:18pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 4faf66c Started: 10/18/2023 06:37:13pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
3% (10)10 / 333 runsfailed over last 7 days |
36.64% (122)122 / 333 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
9.04% (30)30 / 332 runsfailed over last 7 days |
89.46% (297)297 / 332 runsflaked over last 7 days |
What does this PR do?
Support embedding /booking/[uid] page separately
Type of change
How should this be tested?
Try to open an existing booking link with /embed in the end e.g. http://app.cal.local:3000/booking/iHFhuzFdQz3xxCXjHUjSke/embed. It was not required to be supported earlier but now it's supported as requested.
Mandatory Tasks
Checklist