feat: (Overlay) Persist toggle option #11961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
sean-brydon
commented
Oct 18, 2023
Comment on lines
+173
to
+177
| <OverlayCalendarSwitch | ||
| setCalendarSettingsOverlay={setCalendarSettingsOverlay} | ||
| setContinueWithProvider={setContinueWithProvider} | ||
| enabled={switchEnabled} | ||
| /> |
There was a problem hiding this comment.
Extracted into a seperate component to not clog up the container
sean-brydon
commented
Oct 18, 2023
Comment on lines
-79
to
-106
| // Toggle query param for overlay calendar | ||
| const toggleOverlayCalendarQueryParam = useCallback( | ||
| (state: boolean) => { | ||
| const current = new URLSearchParams(Array.from(searchParams.entries())); | ||
| if (state) { | ||
| current.set("overlayCalendar", "true"); | ||
| } else { | ||
| current.delete("overlayCalendar"); | ||
| } | ||
| // cast to string | ||
| const value = current.toString(); | ||
| const query = value ? `?${value}` : ""; | ||
| router.push(`${pathname}${query}`); | ||
| }, | ||
| [searchParams, pathname, router] | ||
| ); | ||
|
|
||
| /** | ||
| * If a user is not logged in and the overlay calendar query param is true, | ||
| * show the continue modal so they can login / create an account | ||
| */ | ||
| useEffect(() => { | ||
| if (!session && overlayCalendarQueryParam === "true") { | ||
| toggleOverlayCalendarQueryParam(false); | ||
| setContinueWithProvider(true); | ||
| } | ||
| }, [session, overlayCalendarQueryParam, toggleOverlayCalendarQueryParam]); | ||
|
|
There was a problem hiding this comment.
Logic has been move to switch component above
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/18/2023 09:34:00am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: af7bb15 Started: 10/18/2023 09:31:09am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
1.75% (5)5 / 285 runsfailed over last 7 days |
29.12% (83)83 / 285 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
3.34% (10)10 / 299 runsfailed over last 7 days |
35.45% (106)106 / 299 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
9.06% (27)27 / 298 runsfailed over last 7 days |
89.60% (267)267 / 298 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Paid booking should be able to be rescheduled
Retry 1 • Initial Attempt |
3.02% (9)9 / 298 runsfailed over last 7 days |
6.38% (19)19 / 298 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Udit-takkar
approved these changes
Oct 18, 2023
Created an issue for this - nice spot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds persistant state to the toggle switch so you dont have to toggle this on every single time you visit a new booking page
Loom: https://www.loom.com/share/aa582bb2c1a2446a99e7cb66c27258fb